Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --key flag for generate commands to specify resource key #1165

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Add --key flag for generate commands to specify resource key #1165

merged 4 commits into from
Jan 31, 2024

Conversation

andrewnester
Copy link
Contributor

Changes

Add --key for generate commands to specify resource key.

Also, resource config files are now not prefixed anymore.

Tests

Integration tests passed

@pietern pietern changed the title Add --key for generate commands to specify resource key Add --key flag for generate commands to specify resource key Jan 31, 2024
pietern
pietern reviewed Jan 31, 2024
View reviewed changes
cmd/bundle/generate.go Outdated Show resolved Hide resolved
cmd/bundle/generate/job.go Outdated Show resolved Hide resolved
andrewnester and others added 2 commits January 31, 2024 10:03
@andrewnester @pietern
Update cmd/bundle/generate.go
2904733 
Co-authored-by: Pieter Noordhuis <pieter.noordhuis@databricks.com>
@andrewnester
fix tests
b736ae1
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (5fda017) 51.51% compared to head (b736ae1) 51.48%.

Files Patch % Lines
cmd/bundle/generate/job.go 0.00% 4 Missing ⚠️
cmd/bundle/generate.go 0.00% 3 Missing ⚠️
cmd/bundle/generate/pipeline.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1165      +/-   ##
==========================================
- Coverage   51.51%   51.48%   -0.03%     
==========================================
  Files         292      292              
  Lines       16322    16331       +9     
==========================================
  Hits         8408     8408              
- Misses       7308     7316       +8     
- Partials      606      607       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewnester andrewnester added this pull request to the merge queue Jan 31, 2024
Merged via the queue into main with commit b28432a Jan 31, 2024
4 checks passed
@andrewnester andrewnester deleted the key-flag-generate branch January 31, 2024 10:28
andrewnester added a commit that referenced this pull request Jan 31, 2024
@andrewnester
Release v0.212.3
5ddf241 
CLI:
 * Release Windows packages to winget-pkgs ([#1144](#1144)).

Bundles:
 * Add `--key` flag for generate commands to specify resource key ([#1165](#1165)).

Dependency updates:
 * Bump github.com/google/uuid from 1.5.0 to 1.6.0 ([#1160](#1160)).
 * Update Go SDK to v0.30.1 ([#1162](#1162)).
@andrewnester andrewnester mentioned this pull request Jan 31, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2024
@andrewnester
Release v0.212.3 (#1166)
359f5f4 
CLI:
* Release Windows packages to winget-pkgs
([#1144](#1144)).

Bundles:
* Add `--key` flag for generate commands to specify resource key
([#1165](#1165)).


Dependency updates:
* Bump github.com/google/uuid from 1.5.0 to 1.6.0
([#1160](#1160)).
* Update Go SDK to v0.30.1
([#1162](#1162)).
shreyas-goenka added a commit that referenced this pull request Feb 1, 2024
@shreyas-goenka
Revert "Add --key flag for generate commands to specify resource key (
eaf8066 
#1165)"

This reverts commit b28432a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietern pietern pietern approved these changes

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewnester @codecov-commenter @pietern