Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate DLT pipelines when deployed using DABs #1410

Merged
merged 4 commits into from
May 1, 2024

Conversation

shreyas-goenka
Copy link
Contributor

@shreyas-goenka shreyas-goenka commented Apr 30, 2024

Changes

This PR annotates any pipelines that were deployed using DABs to have deployment.kind set to "BUNDLE", mirroring the annotation for Jobs (similar PR for jobs FYI: #880).

Breakglass UI is not yet available for pipelines, so this annotation will just be used for revenue attribution ATM.

Note: The API field has been deployed in all regions including GovCloud.

Tests

Unit tests and manually.

Manually verified that the kind and metadata_file_path are being set by DABs, and are returned by a GET API to a pipeline deployed using a DAB. Example:

    "deployment": {
      "kind":"BUNDLE",
      "metadata_file_path":"/Users/shreyas.goenka@databricks.com/.bundle/bundle-playground/default/state/metadata.json"
    },

@shreyas-goenka shreyas-goenka added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit 507053e May 1, 2024
5 checks passed
@shreyas-goenka shreyas-goenka deleted the feature/add-kind-for-pipelines branch May 1, 2024 08:41
andrewnester added a commit that referenced this pull request May 1, 2024
Bundles:
 * Don't fail while parsing outdated terraform state ([#1404](#1404)).
 * Annotate DLT pipelines when deployed using DABs ([#1410](#1410)).

API Changes:
 * Changed `databricks libraries cluster-status` command. New request type is compute.ClusterStatus.
 * Changed `databricks libraries cluster-status` command to return .
 * Added `databricks serving-endpoints get-open-api` command.

OpenAPI commit 21f9f1482f9d0d15228da59f2cd9f0863d2a6d55 (2024-04-23)
Dependency updates:
 * Bump github.com/databricks/databricks-sdk-go from 0.38.0 to 0.39.0 ([#1405](#1405)).
@andrewnester andrewnester mentioned this pull request May 1, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 1, 2024
Bundles:
* Don't fail while parsing outdated terraform state
([#1404](#1404)).
* Annotate DLT pipelines when deployed using DABs
([#1410](#1410)).


API Changes:
* Changed `databricks libraries cluster-status` command. New request
type is compute.ClusterStatus.
 * Changed `databricks libraries cluster-status` command to return .
 * Added `databricks serving-endpoints get-open-api` command.

OpenAPI commit 21f9f1482f9d0d15228da59f2cd9f0863d2a6d55 (2024-04-23)
Dependency updates:
* Bump github.com/databricks/databricks-sdk-go from 0.38.0 to 0.39.0
([#1405](#1405)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants