Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configure command #482

Merged
merged 4 commits into from
Jun 15, 2023
Merged

Update configure command #482

merged 4 commits into from
Jun 15, 2023

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Jun 15, 2023

Changes

This now uses:

  • libs/cmdio to determine interactivity and perform prompting
  • libs/databrickscfg to persist the profile

It loads a config.Config structure from the environment just like we do for unified authentication. It is therefore possible to specify both the host and token with environment variables.

Tests

pieter.noordhuis@L4GHXDT29P /tmp % export DATABRICKS_CONFIG_FILE=.databrickscfg
pieter.noordhuis@L4GHXDT29P /tmp % databricks configure
Databricks Host: https://foo.bar
Personal Access Token: *****
pieter.noordhuis@L4GHXDT29P /tmp % cat .databrickscfg
[DEFAULT]
host  = https://foo.bar
token = token
pieter.noordhuis@L4GHXDT29P /tmp % echo token | databricks configure
Error: host must be set in non-interactive mode
pieter.noordhuis@L4GHXDT29P /tmp % echo token | databricks configure --host foo
Error: must start with https://
pieter.noordhuis@L4GHXDT29P /tmp % echo token | databricks configure --host https://foo
pieter.noordhuis@L4GHXDT29P /tmp % cat .databrickscfg
[DEFAULT]
host  = https://foo
token = token
pieter.noordhuis@L4GHXDT29P /tmp % cat .databrickscfg
pieter.noordhuis@L4GHXDT29P /tmp % databricks configure --host https://foo
Personal Access Token: ******
pieter.noordhuis@L4GHXDT29P /tmp % cat .databrickscfg
[DEFAULT]
host  = https://foo
token = token2

This now uses:
* libs/cmdio to determine interactivity and perform prompting
* libs/databrickscfg to persist the profile

It loads a config.Config structure from the environment just
like we do for unified authentication. It is therefore possible
to specify both the host and token with environment variables.
@pietern pietern enabled auto-merge (squash) June 15, 2023 12:47
@pietern pietern merged commit b9406ef into main Jun 15, 2023
4 checks passed
@pietern pietern deleted the configure branch June 15, 2023 12:52
@pietern pietern mentioned this pull request Jun 15, 2023
pietern added a commit that referenced this pull request Jun 15, 2023
## Changes

CLI:
* Add workspace import-dir command
([#456](#456)).
* Annotate generated commands with OpenAPI package name
([#466](#466)).
* Associate generated commands with command groups
([#475](#475)).
* Disable shell completions for generated commands
([#483](#483)).
* Include [DEFAULT] section header when writing ~/.databrickscfg
([#464](#464)).
* Pass through proxy related environment variables
([#465](#465)).
* Restore flags to original values on test completion
([#470](#470)).
* Update configure command
([#482](#482)).

Dependencies:
* Bump SDK to latest
([#473](#473)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants