Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed environments to targets in bundle configuration #670

Merged
merged 8 commits into from
Aug 17, 2023

Conversation

andrewnester
Copy link
Contributor

Changes

Renamed Environments to Targets in bundle.yml.

The change is backward-compatible and customers can continue to use environments in the time being.

Tests

Added tests which checks that both environments and targets sections in bundle.yml works correctly

bundle/config/environment.go Outdated Show resolved Hide resolved
bundle/config/environment.go Outdated Show resolved Hide resolved
bundle/config/root.go Outdated Show resolved Hide resolved
bundle/config/root.go Outdated Show resolved Hide resolved
bundle/config/root.go Outdated Show resolved Hide resolved
bundle/tests/environment_git_test.go Show resolved Hide resolved
bundle/tests/environment_git_test.go Show resolved Hide resolved
bundle/config/mutator/select_target.go Outdated Show resolved Hide resolved
bundle/config/root.go Outdated Show resolved Hide resolved
bundle/tests/interpolation_test.go Show resolved Hide resolved
cmd/root/bundle.go Outdated Show resolved Hide resolved
cmd/root/bundle.go Show resolved Hide resolved
@pietern pietern changed the title Renamed Environments to Targets in bundle.yml Renamed environments to targets in bundle configuration Aug 17, 2023
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code under bundle/schema has a few mentions of environments still.

bundle/tests/interpolation_test.go Show resolved Hide resolved
cmd/root/bundle.go Outdated Show resolved Hide resolved
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Please TAL at the schema change before merging.

bundle/schema/docs/bundle_descriptions.json Outdated Show resolved Hide resolved
@andrewnester andrewnester added this pull request to the merge queue Aug 17, 2023
Merged via the queue into main with commit 56dcd3f Aug 17, 2023
4 checks passed
@andrewnester andrewnester deleted the env-to-target branch August 17, 2023 15:32
andrewnester added a commit that referenced this pull request Aug 24, 2023
CLI:
 * Added `databricks account o-auth-enrollment enable` command ([#687](#687)).

Bundles:
 * Do not try auto detect Python package if no Python wheel tasks defined ([#674](#674)).
 * Renamed `environments` to `targets` in bundle configuration ([#670](#670)).
 * Rename init project-dir flag to output-dir ([#676](#676)).
 * Added support for sync.include and sync.exclude sections ([#671](#671)).
 * Add template directory flag for bundle templates ([#675](#675)).
 * Never ignore root directory when enumerating files in a repository ([#683](#683)).
 * Improve 'mode' error message ([#681](#681)).
 * Added run_as section for bundle configuration ([#692](#692)).
@andrewnester andrewnester mentioned this pull request Aug 24, 2023
github-merge-queue bot pushed a commit that referenced this pull request Aug 24, 2023
CLI:
* Added `databricks account o-auth-enrollment enable` command
([#687](#687)).

Bundles:
* Do not try auto detect Python package if no Python wheel tasks defined
([#674](#674)).
* Renamed `environments` to `targets` in bundle configuration
([#670](#670)).
* Rename init project-dir flag to output-dir
([#676](#676)).
* Added support for sync.include and sync.exclude sections
([#671](#671)).
* Add template directory flag for bundle templates
([#675](#675)).
* Never ignore root directory when enumerating files in a repository
([#683](#683)).
* Improve 'mode' error message
([#681](#681)).
* Added run_as section for bundle configuration
([#692](#692)).
arpitjasa-db pushed a commit to arpitjasa-db/cli that referenced this pull request Sep 7, 2023
CLI:
* Added `databricks account o-auth-enrollment enable` command
([databricks#687](databricks#687)).

Bundles:
* Do not try auto detect Python package if no Python wheel tasks defined
([databricks#674](databricks#674)).
* Renamed `environments` to `targets` in bundle configuration
([databricks#670](databricks#670)).
* Rename init project-dir flag to output-dir
([databricks#676](databricks#676)).
* Added support for sync.include and sync.exclude sections
([databricks#671](databricks#671)).
* Add template directory flag for bundle templates
([databricks#675](databricks#675)).
* Never ignore root directory when enumerating files in a repository
([databricks#683](databricks#683)).
* Improve 'mode' error message
([databricks#681](databricks#681)).
* Added run_as section for bundle configuration
([databricks#692](databricks#692)).

Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants