Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test transform when no Python wheel tasks defined #714

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Conversation

andrewnester
Copy link
Contributor

Changes

Fixed panic from Python transform when no python wheel tasks defined

Tests

Added regression test

Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep the test in place if it makes sense.

Duplicate PR at #712.

@pietern pietern changed the title Fixed panic from Python transform when no python wheel tasks defined Test transform when no Python wheel tasks defined Aug 30, 2023
@andrewnester andrewnester added this pull request to the merge queue Aug 30, 2023
Merged via the queue into main with commit a548eba Aug 30, 2023
4 checks passed
@andrewnester andrewnester deleted the fix-whl-panic branch August 30, 2023 14:17
@andrewnester andrewnester mentioned this pull request Aug 30, 2023
andrewnester added a commit that referenced this pull request Aug 30, 2023
Bundles:
 * Support cluster overrides with cluster_key and compute_key ([#696](#696)).
 * Allow referencing local Python wheels without artifacts section defined ([#703](#703)).
 * Fixed --environment flag ([#705](#705)).
 * Correctly identify local paths in libraries section ([#702](#702)).
 * Fixed path joining in FindFilesWithSuffixInPath ([#704](#704)).
 *  Added transformation mutator for Python wheel task for them to work on DBR <13.1 ([#635](#635)).

Internal:
 * Add a foundation for built-in templates ([#685](#685)).
 * Test transform when no Python wheel tasks defined ([#714](#714)).
 * Pin Terraform binary version to 1.5.5 ([#715](#715)).
 * Cleanup after "Add a foundation for built-in templates" ([#707](#707)).
 * Filter down to Python wheel tasks only for trampoline ([#712](#712)).
 * Update Terraform provider schema structs from 1.23.0 ([#713](#713)).
github-merge-queue bot pushed a commit that referenced this pull request Aug 30, 2023
Bundles:
* Support cluster overrides with cluster_key and compute_key
([#696](#696)).
* Allow referencing local Python wheels without artifacts section
defined ([#703](#703)).
* Fixed --environment flag
([#705](#705)).
* Correctly identify local paths in libraries section
([#702](#702)).
* Fixed path joining in FindFilesWithSuffixInPath
([#704](#704)).
* Added transformation mutator for Python wheel task for them to work on
DBR <13.1 ([#635](#635)).

Internal:
* Add a foundation for built-in templates
([#685](#685)).
* Test transform when no Python wheel tasks defined
([#714](#714)).
* Pin Terraform binary version to 1.5.5
([#715](#715)).
* Cleanup after "Add a foundation for built-in templates"
([#707](#707)).
* Filter down to Python wheel tasks only for trampoline
([#712](#712)).
* Update Terraform provider schema structs from 1.23.0
([#713](#713)).
lennartkats-db pushed a commit that referenced this pull request Sep 1, 2023
## Changes
Fixed panic from Python transform when no python wheel tasks defined

## Tests
Added regression test
lennartkats-db pushed a commit that referenced this pull request Sep 1, 2023
Bundles:
* Support cluster overrides with cluster_key and compute_key
([#696](#696)).
* Allow referencing local Python wheels without artifacts section
defined ([#703](#703)).
* Fixed --environment flag
([#705](#705)).
* Correctly identify local paths in libraries section
([#702](#702)).
* Fixed path joining in FindFilesWithSuffixInPath
([#704](#704)).
* Added transformation mutator for Python wheel task for them to work on
DBR <13.1 ([#635](#635)).

Internal:
* Add a foundation for built-in templates
([#685](#685)).
* Test transform when no Python wheel tasks defined
([#714](#714)).
* Pin Terraform binary version to 1.5.5
([#715](#715)).
* Cleanup after "Add a foundation for built-in templates"
([#707](#707)).
* Filter down to Python wheel tasks only for trampoline
([#712](#712)).
* Update Terraform provider schema structs from 1.23.0
([#713](#713)).
arpitjasa-db pushed a commit to arpitjasa-db/cli that referenced this pull request Sep 7, 2023
## Changes
Fixed panic from Python transform when no python wheel tasks defined

## Tests
Added regression test

Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
arpitjasa-db pushed a commit to arpitjasa-db/cli that referenced this pull request Sep 7, 2023
Bundles:
* Support cluster overrides with cluster_key and compute_key
([databricks#696](databricks#696)).
* Allow referencing local Python wheels without artifacts section
defined ([databricks#703](databricks#703)).
* Fixed --environment flag
([databricks#705](databricks#705)).
* Correctly identify local paths in libraries section
([databricks#702](databricks#702)).
* Fixed path joining in FindFilesWithSuffixInPath
([databricks#704](databricks#704)).
* Added transformation mutator for Python wheel task for them to work on
DBR <13.1 ([databricks#635](databricks#635)).

Internal:
* Add a foundation for built-in templates
([databricks#685](databricks#685)).
* Test transform when no Python wheel tasks defined
([databricks#714](databricks#714)).
* Pin Terraform binary version to 1.5.5
([databricks#715](databricks#715)).
* Cleanup after "Add a foundation for built-in templates"
([databricks#707](databricks#707)).
* Filter down to Python wheel tasks only for trampoline
([databricks#712](databricks#712)).
* Update Terraform provider schema structs from 1.23.0
([databricks#713](databricks#713)).

Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants