Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when unknown keys are encounters during template execution #766

Merged
merged 10 commits into from
Sep 14, 2023

Conversation

shreyas-goenka
Copy link
Contributor

Tests

New unit test and manually

@shreyas-goenka
Copy link
Contributor Author

End to end error on incorrect key usage:
Screenshot 2023-09-12 at 11 26 03 AM

Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewnester Please also take a look.

libs/template/renderer.go Show resolved Hide resolved
libs/template/renderer.go Show resolved Hide resolved
internal/init_test.go Show resolved Hide resolved
libs/template/renderer.go Show resolved Hide resolved
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Final set of comments.

libs/template/renderer.go Outdated Show resolved Hide resolved
internal/init_test.go Show resolved Hide resolved
@shreyas-goenka shreyas-goenka added this pull request to the merge queue Sep 14, 2023
Merged via the queue into main with commit 327ab0e Sep 14, 2023
4 checks passed
@shreyas-goenka shreyas-goenka deleted the error-on-unknown-keys branch September 14, 2023 15:58
pietern added a commit that referenced this pull request Sep 20, 2023
Bundles:
 * Use enums for default python template ([#765](#765)).
 * Make bundle deploy work if no resources are defined ([#767](#767)).
 * Added support for experimental scripts section ([#632](#632)).
 * Error when unknown keys are encounters during template execution ([#766](#766)).
 * Fall back to full Git clone if shallow clone is not supported ([#775](#775)).
 * Enable environment overrides for job tasks ([#779](#779)).
 * Increase timeout waiting for job run to 1 day ([#786](#786)).

Internal:
 * Update Go SDK to v0.19.3 (unreleased) ([#778](#778)).
@pietern pietern mentioned this pull request Sep 20, 2023
github-merge-queue bot pushed a commit that referenced this pull request Sep 20, 2023
Bundles:
* Use enums for default python template
([#765](#765)).
* Make bundle deploy work if no resources are defined
([#767](#767)).
* Added support for experimental scripts section
([#632](#632)).
* Error when unknown keys are encounters during template execution
([#766](#766)).
* Fall back to full Git clone if shallow clone is not supported
([#775](#775)).
* Enable environment overrides for job tasks
([#779](#779)).
* Increase timeout waiting for job run to 1 day
([#786](#786)).

Internal:
* Update Go SDK to v0.19.3 (unreleased)
([#778](#778)).
hectorcast-db pushed a commit that referenced this pull request Oct 13, 2023
hectorcast-db pushed a commit that referenced this pull request Oct 13, 2023
Bundles:
* Use enums for default python template
([#765](#765)).
* Make bundle deploy work if no resources are defined
([#767](#767)).
* Added support for experimental scripts section
([#632](#632)).
* Error when unknown keys are encounters during template execution
([#766](#766)).
* Fall back to full Git clone if shallow clone is not supported
([#775](#775)).
* Enable environment overrides for job tasks
([#779](#779)).
* Increase timeout waiting for job run to 1 day
([#786](#786)).

Internal:
* Update Go SDK to v0.19.3 (unreleased)
([#778](#778)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants