Use already instantiated WorkspaceClient in sync command #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
approved these changes
Oct 13, 2023
|
Could you double check if we have other call-sites in the code where we don't go through |
|
@pietern all the other usage of .NewWorkspaceClient are either tests or used for configuring a new client so they are accurate |
pietern
added a commit
that referenced
this pull request
Oct 16, 2023
Note: this release includes a fix for the issue where zero values (for example `num_workers: 0`) were not included in the request body. CLI: * Use already instantiated WorkspaceClient in sync command ([#867](#867)). Bundles: * Support Unity Catalog Registered Models in bundles ([#846](#846)). * Fixed merging task libraries from targets ([#868](#868)). * Add alias for mlops-stack template URL ([#869](#869)). API Changes: * Changed `databricks account billable-usage download` command to start returning output. * Changed `databricks account storage-credentials delete` command with new required argument order. * Changed `databricks account storage-credentials get` command with new required argument order. * Changed `databricks account storage-credentials update` command with new required argument order. * Added `databricks workspace-bindings get-bindings` command. * Added `databricks workspace-bindings update-bindings` command. * Removed `databricks account network-policy` command group. * Changed `databricks ip-access-lists list` command to return output. OpenAPI commit 493a76554afd3afdd15dc858773d01643f80352a (2023-10-12) Dependency updates: * Update Go SDK to 0.23.0 and use custom marshaller ([#772](#772)). * Bump Terraform provider to v1.28.0 ([#871](#871)). * Bump golang.org/x/net from 0.16.0 to 0.17.0 ([#863](#863)). * Bump github.com/hashicorp/hc-install from 0.6.0 to 0.6.1 ([#870](#870)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
Note: this release includes a fix for the issue where zero values (for example `num_workers: 0`) were not included in the request body. CLI: * Use already instantiated WorkspaceClient in sync command ([#867](#867)). Bundles: * Support Unity Catalog Registered Models in bundles ([#846](#846)). * Fixed merging task libraries from targets ([#868](#868)). * Add alias for mlops-stack template URL ([#869](#869)). API Changes: * Changed `databricks account billable-usage download` command to start returning output. * Changed `databricks account storage-credentials delete` command with new required argument order. * Changed `databricks account storage-credentials get` command with new required argument order. * Changed `databricks account storage-credentials update` command with new required argument order. * Added `databricks workspace-bindings get-bindings` command. * Added `databricks workspace-bindings update-bindings` command. * Removed `databricks account network-policy` command group. * Changed `databricks ip-access-lists list` command to return output. OpenAPI commit 493a76554afd3afdd15dc858773d01643f80352a (2023-10-12) Dependency updates: * Update Go SDK to 0.23.0 and use custom marshaller ([#772](#772)). * Bump Terraform provider to v1.28.0 ([#871](#871)). * Bump golang.org/x/net from 0.16.0 to 0.17.0 ([#863](#863)). * Bump github.com/hashicorp/hc-install from 0.6.0 to 0.6.1 ([#870](#870)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Since we use
root.MustWorkspaceClientnow, we should use already initialised version of WorkspaceClient instead of instantiating a new one.Fixes #836