Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .databrickscfg to .gitignore. #370

Merged
merged 1 commit into from Aug 20, 2021
Merged

Add .databrickscfg to .gitignore. #370

merged 1 commit into from Aug 20, 2021

Conversation

stormwindy
Copy link
Collaborator

To prevent developers pushing their configuration file by mistake and leaking tokens, hostnames this PR adds .databrickscfg to .gitignore. Such leak is a possible scenario if developer starts docker from the root of the project in which case .databrickscfg file will be created in the root directory of the repository.

@stormwindy stormwindy self-assigned this May 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2021

Codecov Report

Merging #370 (765b6f1) into master (2dd60cf) will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
+ Coverage   84.57%   84.83%   +0.25%     
==========================================
  Files          39       39              
  Lines        2730     2724       -6     
==========================================
+ Hits         2309     2311       +2     
+ Misses        421      413       -8     
Impacted Files Coverage Δ
databricks_cli/pipelines/api.py 96.39% <0.00%> (+0.03%) ⬆️
databricks_cli/pipelines/cli.py 93.79% <0.00%> (+4.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd60cf...765b6f1. Read the comment docs.

@stormwindy stormwindy merged commit 290e9f6 into databricks:master Aug 20, 2021
@stormwindy stormwindy deleted the databrickscfg_gitignore branch August 20, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants