[JOBS-13997] Add SdkJobsUtils and fix taskValuesUtils in proxy mode #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborratky-db
suggested changes
Oct 23, 2023
databricks-dbutils-scala/src/main/scala/com/databricks/sdk/scala/dbutils/DBUtils.scala
Outdated
Show resolved
Hide resolved
Comment on lines
171
to
172
| private var commandContext = | ||
| CommandContext() |
There was a problem hiding this comment.
Do we need an instance here? It seems our integration does not rely on it. Can this be private var commandContext: CommandContext = _?
There was a problem hiding this comment.
I check that initially getContext returns empty context
databricks-dbutils-scala/src/main/scala/com/databricks/sdk/scala/dbutils/SdkDBUtilsImpl.scala
Outdated
Show resolved
Hide resolved
databricks-dbutils-scala/src/main/scala/com/databricks/sdk/scala/dbutils/SdkDBUtilsImpl.scala
Outdated
Show resolved
Hide resolved
...c/test/scala/com/databricks/sdk/scala/dbutils/integration/SdkTaskValuesIntegrationTest.scala
Outdated
Show resolved
Hide resolved
...c/test/scala/com/databricks/sdk/scala/dbutils/integration/SdkTaskValuesIntegrationTest.scala
Outdated
Show resolved
Hide resolved
...c/test/scala/com/databricks/sdk/scala/dbutils/integration/SdkTaskValuesIntegrationTest.scala
Outdated
Show resolved
Hide resolved
...c/test/scala/com/databricks/sdk/scala/dbutils/integration/SdkTaskValuesIntegrationTest.scala
Outdated
Show resolved
Hide resolved
...c/test/scala/com/databricks/sdk/scala/dbutils/integration/SdkTaskValuesIntegrationTest.scala
Outdated
Show resolved
Hide resolved
gaborratky-db
suggested changes
Nov 1, 2023
There was a problem hiding this comment.
setJson should not throw, otherwise the SDK cannot be used for local development when the customer relies on setJson on top of DBR.
I will defer final review to @mgyucht.
databricks-dbutils-scala/src/main/scala/com/databricks/sdk/scala/dbutils/SdkDBUtilsImpl.scala
Outdated
Show resolved
Hide resolved
mgyucht
reviewed
Nov 1, 2023
databricks-dbutils-scala/src/main/scala/com/databricks/sdk/scala/dbutils/SdkDBUtilsImpl.scala
Outdated
Show resolved
Hide resolved
databricks-dbutils-scala/src/main/scala/com/databricks/sdk/scala/dbutils/ProxyDBUtilsImpl.scala
Show resolved
Hide resolved
databricks-dbutils-scala/src/main/scala/com/databricks/sdk/scala/dbutils/SdkDBUtilsImpl.scala
Show resolved
Hide resolved
databricks-dbutils-scala/src/main/scala/com/databricks/sdk/scala/dbutils/SdkDBUtilsImpl.scala
Outdated
Show resolved
Hide resolved
databricks-dbutils-scala/src/main/scala/com/databricks/sdk/scala/dbutils/SdkDBUtilsImpl.scala
Outdated
Show resolved
Hide resolved
...c/test/scala/com/databricks/sdk/scala/dbutils/integration/SdkTaskValuesIntegrationTest.scala
Outdated
Show resolved
Hide resolved
mgyucht
approved these changes
Nov 1, 2023
databricks-dbutils-scala/src/main/scala/com/databricks/sdk/scala/dbutils/ProxyDBUtilsImpl.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
taskValuesin proxy mode, because it is not field, but methodTests