Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md #585

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Add CONTRIBUTING.md #585

merged 1 commit into from
Mar 15, 2024

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented Mar 15, 2024

Changes

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mgyucht mgyucht enabled auto-merge March 15, 2024 18:25
@mgyucht mgyucht added this pull request to the merge queue Mar 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.03%. Comparing base (33b209b) to head (9941b8d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
- Coverage   58.03%   58.03%   -0.01%     
==========================================
  Files          44       44              
  Lines       30042    30042              
==========================================
- Hits        17435    17434       -1     
- Misses      12607    12608       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit b239ab1 Mar 15, 2024
9 checks passed
@mgyucht mgyucht deleted the contributing branch March 15, 2024 18:27
mgyucht added a commit that referenced this pull request Mar 20, 2024
* Add CONTRIBUTING.md ([#585](#585)).

API Changes:

 * Added `databricks.sdk.service.catalog.AwsIamRoleRequest` dataclass.
 * Added `databricks.sdk.service.catalog.AwsIamRoleResponse` dataclass.
 * Removed `databricks.sdk.service.catalog.AwsIamRole` dataclass.
 * Changed `aws_iam_role` field for `databricks.sdk.service.catalog.CreateStorageCredential` to [~] catalog.AwsIamRoleRequest entity.
 * Changed `aws_iam_role` field for `databricks.sdk.service.catalog.StorageCredentialInfo` to [~] catalog.AwsIamRoleResponse entity.
 * Changed `aws_iam_role` field for `databricks.sdk.service.catalog.UpdateStorageCredential` to [~] catalog.AwsIamRoleRequest entity.
 * Changed `aws_iam_role` field for `databricks.sdk.service.catalog.ValidateStorageCredential` to [~] catalog.AwsIamRoleRequest entity.
 * Changed `get()` method for [w.lakeview](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/lakeview.html) workspace-level service . New request type is [~] dashboards.GetDashboardRequest entity.
 * Changed `get_published()` method for [w.lakeview](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/lakeview.html) workspace-level service . New request type is [~] dashboards.GetPublishedDashboardRequest entity.
 * Changed `trash()` method for [w.lakeview](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/lakeview.html) workspace-level service . New request type is [~] dashboards.TrashDashboardRequest entity.
 * Removed `databricks.sdk.service.dashboards.GetLakeviewRequest` dataclass.
 * Removed `databricks.sdk.service.dashboards.GetPublishedRequest` dataclass.
 * Added `databricks.sdk.service.dashboards.GetDashboardRequest` dataclass.
 * Added `databricks.sdk.service.dashboards.TrashDashboardRequest` dataclass.
 * Removed `databricks.sdk.service.dashboards.TrashRequest` dataclass.
 * Added `databricks.sdk.service.dashboards.GetPublishedDashboardRequest` dataclass.
 * Added `auto_capture_config` field for `databricks.sdk.service.serving.EndpointPendingConfig`.
 * Removed `databricks.sdk.service.settings.GetIpAccessListRequest` dataclass.
 * Added `databricks.sdk.service.settings.GetDefaultNamespaceSettingRequest` dataclass.
 * Added `databricks.sdk.service.settings.GetEsmEnablementAccountSettingRequest` dataclass.
 * Changed `get()` method for [w.automatic_cluster_update](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/automatic_cluster_update.html) workspace-level service . New request type is [~] settings.GetAutomaticClusterUpdateSettingRequest entity.
 * Changed `get()` method for [w.esm_enablement](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/esm_enablement.html) workspace-level service . New request type is [~] settings.GetEsmEnablementSettingRequest entity.
 * Removed `databricks.sdk.service.settings.GetCspEnablementRequest` dataclass.
 * Added `databricks.sdk.service.settings.GetEsmEnablementSettingRequest` dataclass.
 * Removed `databricks.sdk.service.settings.GetPersonalComputeRequest` dataclass.
 * Added `databricks.sdk.service.settings.DeletePersonalComputeSettingRequest` dataclass.
 * Added `databricks.sdk.service.settings.GetAutomaticClusterUpdateSettingRequest` dataclass.
 * Added `databricks.sdk.service.settings.GetCspEnablementAccountSettingRequest` dataclass.
 * Changed `get()` method for [a.esm_enablement_account](https://databricks-sdk-py.readthedocs.io/en/latest/account/esm_enablement_account.html) account-level service . New request type is [~] settings.GetEsmEnablementAccountSettingRequest entity.
 * Changed `get()` method for [w.restrict_workspace_admins](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/restrict_workspace_admins.html) workspace-level service . New request type is [~] settings.GetRestrictWorkspaceAdminsSettingRequest entity.
 * Removed `databricks.sdk.service.settings.DeleteDefaultNamespaceRequest` dataclass.
 * Removed `databricks.sdk.service.settings.DeleteRestrictWorkspaceAdminRequest` dataclass.
 * Removed `databricks.sdk.service.settings.GetEsmEnablementRequest` dataclass.
 * Removed `databricks.sdk.service.settings.GetRestrictWorkspaceAdminRequest` dataclass.
 * Added `databricks.sdk.service.settings.DeleteRestrictWorkspaceAdminsSettingRequest` dataclass.
 * Added `databricks.sdk.service.settings.GetRestrictWorkspaceAdminsSettingRequest` dataclass.
 * Changed `delete()` method for [w.default_namespace](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/default_namespace.html) workspace-level service . New request type is [~] settings.DeleteDefaultNamespaceSettingRequest entity.
 * Changed `get()` method for [a.personal_compute](https://databricks-sdk-py.readthedocs.io/en/latest/account/personal_compute.html) account-level service . New request type is [~] settings.GetPersonalComputeSettingRequest entity.
 * Removed `databricks.sdk.service.settings.DeletePersonalComputeRequest` dataclass.
 * Removed `databricks.sdk.service.settings.GetDefaultNamespaceRequest` dataclass.
 * Changed `get()` method for [w.ip_access_lists](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/ip_access_lists.html) workspace-level service . New request type is [~] settings.GetIpAccessList entity.
 * Changed `get()` method for [w.default_namespace](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/default_namespace.html) workspace-level service . New request type is [~] settings.GetDefaultNamespaceSettingRequest entity.
 * Removed `databricks.sdk.service.settings.GetAutomaticClusterUpdateRequest` dataclass.
 * Added `databricks.sdk.service.settings.DeleteDefaultNamespaceSettingRequest` dataclass.
 * Added `databricks.sdk.service.settings.GetPersonalComputeSettingRequest` dataclass.
 * Added `databricks.sdk.service.settings.GetCspEnablementSettingRequest` dataclass.
 * Added `databricks.sdk.service.settings.GetIpAccessList` dataclass.
 * Changed `get()` method for [w.csp_enablement](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/csp_enablement.html) workspace-level service . New request type is [~] settings.GetCspEnablementSettingRequest entity.
 * Changed `delete()` method for [a.personal_compute](https://databricks-sdk-py.readthedocs.io/en/latest/account/personal_compute.html) account-level service . New request type is [~] settings.DeletePersonalComputeSettingRequest entity.
 * Changed `delete()` method for [w.restrict_workspace_admins](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/restrict_workspace_admins.html) workspace-level service . New request type is [~] settings.DeleteRestrictWorkspaceAdminsSettingRequest entity.
 * Removed `databricks.sdk.service.settings.GetCspEnablementAccountRequest` dataclass.
 * Changed `get()` method for [a.csp_enablement_account](https://databricks-sdk-py.readthedocs.io/en/latest/account/csp_enablement_account.html) account-level service . New request type is [~] settings.GetCspEnablementAccountSettingRequest entity.
 * Removed `databricks.sdk.service.settings.GetEsmEnablementAccountRequest` dataclass.
 * Changed `data_object_type` field for `databricks.sdk.service.sharing.SharedDataObject` to [~] SharedDataObjectDataObjectType entity.
 * Added `content` field for `databricks.sdk.service.sharing.SharedDataObject`.
 * Added `databricks.sdk.service.sharing.SharedDataObjectDataObjectType` dataclass.
 * Added `embedding_source_columns` field for `databricks.sdk.service.vectorsearch.DirectAccessVectorIndexSpec`.

OpenAPI SHA: 93763b0d7ae908520c229c786fff28b8fd623261, Date: 2024-03-20
@mgyucht mgyucht mentioned this pull request Mar 20, 2024
mgyucht added a commit that referenced this pull request Mar 20, 2024
* Add CONTRIBUTING.md ([#585](#585)).

API Changes:

 * Added `databricks.sdk.service.catalog.AwsIamRoleResponse` dataclass.
 * Added `databricks.sdk.service.catalog.AwsIamRoleRequest` dataclass.
 * Removed `databricks.sdk.service.catalog.AwsIamRole` dataclass.
 * Changed `aws_iam_role` field for `databricks.sdk.service.catalog.CreateStorageCredential` to `databricks.sdk.service.catalog.AwsIamRoleRequest` dataclass.
 * Changed `aws_iam_role` field for `databricks.sdk.service.catalog.StorageCredentialInfo` to `databricks.sdk.service.catalog.AwsIamRoleResponse` dataclass.
 * Changed `aws_iam_role` field for `databricks.sdk.service.catalog.UpdateStorageCredential` to `databricks.sdk.service.catalog.AwsIamRoleRequest` dataclass.
 * Changed `aws_iam_role` field for `databricks.sdk.service.catalog.ValidateStorageCredential` to `databricks.sdk.service.catalog.AwsIamRoleRequest` dataclass.
 * Added `auto_capture_config` field for `databricks.sdk.service.serving.EndpointPendingConfig`.
 * Added `databricks.sdk.service.sharing.SharedDataObjectDataObjectType` dataclass.
 * Changed `data_object_type` field for `databricks.sdk.service.sharing.SharedDataObject` to `databricks.sdk.service.sharing.SharedDataObjectDataObjectType` dataclass.
 * Added `content` field for `databricks.sdk.service.sharing.SharedDataObject`.
 * Added `embedding_source_columns` field for `databricks.sdk.service.vectorsearch.DirectAccessVectorIndexSpec`.

OpenAPI SHA: 93763b0d7ae908520c229c786fff28b8fd623261, Date: 2024-03-20
github-merge-queue bot pushed a commit that referenced this pull request Mar 20, 2024
Internal changes:

* Add CONTRIBUTING.md
([#585](#585)).
* Improve diff generation for changelog.

API Changes:

 * Added `databricks.sdk.service.catalog.AwsIamRoleResponse` dataclass.
 * Added `databricks.sdk.service.catalog.AwsIamRoleRequest` dataclass.
 * Removed `databricks.sdk.service.catalog.AwsIamRole` dataclass.
* Changed `aws_iam_role` field for
`databricks.sdk.service.catalog.CreateStorageCredential` to
`databricks.sdk.service.catalog.AwsIamRoleRequest` dataclass.
* Changed `aws_iam_role` field for
`databricks.sdk.service.catalog.StorageCredentialInfo` to
`databricks.sdk.service.catalog.AwsIamRoleResponse` dataclass.
* Changed `aws_iam_role` field for
`databricks.sdk.service.catalog.UpdateStorageCredential` to
`databricks.sdk.service.catalog.AwsIamRoleRequest` dataclass.
* Changed `aws_iam_role` field for
`databricks.sdk.service.catalog.ValidateStorageCredential` to
`databricks.sdk.service.catalog.AwsIamRoleRequest` dataclass.
* Added `auto_capture_config` field for
`databricks.sdk.service.serving.EndpointPendingConfig`.
* Added `databricks.sdk.service.sharing.SharedDataObjectDataObjectType`
dataclass.
* Changed `data_object_type` field for
`databricks.sdk.service.sharing.SharedDataObject` to
`databricks.sdk.service.sharing.SharedDataObjectDataObjectType`
dataclass.
* Added `content` field for
`databricks.sdk.service.sharing.SharedDataObject`.
* Added `embedding_source_columns` field for
`databricks.sdk.service.vectorsearch.DirectAccessVectorIndexSpec`.

OpenAPI SHA: 93763b0d7ae908520c229c786fff28b8fd623261, Date: 2024-03-20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants