Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing error types #117

Merged
merged 8 commits into from
Apr 17, 2023
Merged

Implementing error types #117

merged 8 commits into from
Apr 17, 2023

Commits on Mar 15, 2023

  1. Implementing error types 

    Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
    @mattdeekay
    mattdeekay committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    cb4b41d View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Public error types 

    Refactored so that the interfaces for system, request, and execution errors are public in dbsql/errors.
Updated error implementations to work better with errors.Is() and errors.As().
Added sentinel values (SystemFault, RequestError, ExecutionError) in dbsql/errors to use with errors.Is()
Updated doc.go to include error information.
Updated errors examples.

Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
    @rcypher-databricks
    rcypher-databricks committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    aff1bc8 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Extended use of public error types 

    - updated rows package to use the new public error types
- refactored arrow/column based rows to put errors into a separate file
Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
    @rcypher-databricks
    rcypher-databricks committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    fb50b06 View commit details
    Browse the repository at this point in the history

  2. gofmt-ed files 

    Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
    @rcypher-databricks
    rcypher-databricks committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    0cef7a7 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Changes based on review. 

    Made error messages public.
Renamed SystemFault to DriverError.
Fixed a few places where we were returning the wrong type of error.
Fixed a code path that would crash when the sentinel timed out.

Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
    @rcypher-databricks
    rcypher-databricks committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    c5b8e94 View commit details
    Browse the repository at this point in the history

  2. Updated string literal in driver error 

    Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
    @rcypher-databricks
    rcypher-databricks committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    b8ad0d7 View commit details
    Browse the repository at this point in the history

  3. Fixed whitespace issue for linter 

    Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
    @rcypher-databricks
    rcypher-databricks committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    751ae8c View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Updated error handling example 

    New example and fixed issues with errors.Is() and setting query id into context.

Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
    @rcypher-databricks
    rcypher-databricks committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    adc53f8 View commit details
    Browse the repository at this point in the history