Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of bad connection errors and specifying server protocol. #152

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Better handling of bad connection errors and specifying server protocol. #152

merged 1 commit into from
Aug 30, 2023

Commits on Aug 2, 2023

  1. Added a new error type that identifies as driver.ErrBadConn. This can… 

    … be added in to an error chain to signal that a connection should no longer be used and to retry with a new connection.

Updated ThriftServiceClient error handling. When a Thrift request fails we are now checking the error message for the term 'Invalid SessionHandle'.  If it is present we are adding a bad connection error to the error chain.  Searching in the error message is clumsy and fragile but there doesn't currently appear to be another way to get the information.

Updated the WithServerHostname function to handle host names prefixed by 'http:' or 'https:' to allow users to specify which protocol to use.  This is in response to github issue databricks#140.

Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
    @rcypher-databricks
    rcypher-databricks committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    6330b1b View commit details
    Browse the repository at this point in the history