Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement: openpyxl #316

Open
davebelais opened this issue Jan 11, 2024 · 4 comments
Open

Remove requirement: openpyxl #316

davebelais opened this issue Jan 11, 2024 · 4 comments

Comments

@davebelais
Copy link

You include openpyxl as a requirement for this package, however openpyxl is not used by this library, as you can see from this search. Please remove this requirement to reduce bloat in applications/libraries dependent on this package. Thanks!

@susodapop
Copy link
Contributor

This is a good catch. openpyxl is the seventh largest dependency of databricks-sql-connector weighing in at 1.98mb. And we have a big effort underway to reduce the overall installation size. Pull requests will be incoming for this in the next week or so.

openpyxl isn't used by the connector but it is used as part of our e2e test suite. The solution is to simply move it in pyproject.toml so that it's only installed in development mode.

@MichaelAnckaert
Copy link

+1 for this idea. The size of the total install size is very large IMO.

FYI: I'm currently trying to work around the issue where adding databricks-sql-python to a lambda function causes the function size to balloon over the 250Mb limit.

@joeraver
Copy link

+1 Same issue

@susodapop
Copy link
Contributor

@MichaelAnckaert the biggest culprits for install size are pyarrow and numpy. Remove openpyxl makes sense towards the same goal but comprises a small fraction of the total install size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants