Feature/incremental predicates #161
Conversation
…ors-3/dbt-databricks into feature/incremental-predicates
dbt/include/databricks/macros/materializations/incremental/incremental.sql
Outdated
Show resolved
Hide resolved
dbt/include/databricks/macros/materializations/incremental/incremental.sql
Outdated
Show resolved
Hide resolved
dave-connors-3
requested review from
ueshin
and removed request for
allisonwang-db
tests/integration/incremental_strategies/test_incremental_strategies.py
Outdated
Show resolved
Hide resolved
|
@ueshin thank you for the review! I believe i've addressed the outstanding issues! |
|
Hi @dave-connors-3, now that the PRs for |
| from dbt.tests.adapter.incremental.test_incremental_predicates import BaseIncrementalPredicates | ||
|
|
||
|
|
||
| models__spark_incremental_predicates_sql = """ |
There was a problem hiding this comment.
Do we need to re-define this?
There was a problem hiding this comment.
i believe I needed to redefine this in my dbt-spark PR, and I assumed I needed to do the same here.
i did just run the SQL in databricks without the cast function and it seemed to execute. I can remove this if we don't think this is necessary!
There was a problem hiding this comment.
Shall we just rename it to models__databricks_incremental_predicates_sql, then?
…ors-3/dbt-databricks into feature/incremental-predicates
|
Why was |
Totally by mistake! restored the file |
There was a problem hiding this comment.
LGTM, pending linter.
@dave-connors-3 Could you run black again?
|
@ueshin i think black is passing, but flake8 line length checks are failing |
|
@dave-connors-3 Yeah, sometimes |
|
Thanks! merging. |
resolves #160
Description
Updates the incremental materialization to include user supplied
incremental_predicatesand passes that to thedbt_spark_get_incremental_sqlmacro.The changes to
dbt_spark_get_incremental_sqlare updated in dbt-spark PR #436Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.