Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dbt incremental_strategy behavior by fixing schema table existing check #530

Merged
merged 6 commits into from Jan 12, 2024
Merged

Fix dbt incremental_strategy behavior by fixing schema table existing check #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1c02106
update-schema-check-validation
case-k-git Dec 9, 2023
9a8c1e4
refactor schema check function
case-k-git Dec 9, 2023
7fb8a17
fix schema check when executing incremental method
case-k-git Dec 29, 2023
7787337
Merge branch 'main' into faeture/update-schema-check-validation
case-k-git Jan 12, 2024
0e30975
update CHANGELOG.md
case-k-git Jan 12, 2024
ac0cab6
Update CHANGELOG.md
benc-db Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -4,6 +4,7 @@

- Fix for issue where long-running python models led to invalid session errors ([544](https://github.com/databricks/dbt-databricks/pull/544))
- Allow schema to be specified in testing (thanks @case-k-git!) ([538](https://github.com/databricks/dbt-databricks/pull/538))
- Fix dbt incremental_strategy behavior by fixing schema table existing check (thanks @case-k-git!) ([530](https://github.com/databricks/dbt-databricks/pull/530))

## dbt-databricks 1.7.3 (Dec 12, 2023)

Expand Down
4 changes: 2 additions & 2 deletions dbt/adapters/databricks/connections.py
View file
Open in desktop
Expand Up @@ -1187,15 +1187,15 @@ def _execute_cursor(
def list_schemas(self, database: str, schema: Optional[str] = None) -> Table:
database = database.strip("`")
if schema:
schema = schema.strip("`")
schema = schema.strip("`").lower()
return self._execute_cursor(
f"GetSchemas(database={database}, schema={schema})",
lambda cursor: cursor.schemas(catalog_name=database, schema_name=schema),
)

def list_tables(self, database: str, schema: str, identifier: Optional[str] = None) -> Table:
database = database.strip("`")
schema = schema.strip("`")
schema = schema.strip("`").lower()
if identifier:
identifier = identifier.strip("`")
return self._execute_cursor(
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/incremental_strategies/test_incremental_strategies.py
View file
Open in desktop
Expand Up @@ -4,7 +4,7 @@
class TestIncrementalStrategies(DBTIntegrationTest):
@property
def schema(self):
return "incremental_strategies"
return "Incremental_strategies"

@property
def project_config(self):
Expand Down