Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loc with slice when the index is monotonically decreasing. #1179

Merged
merged 1 commit into from Jan 9, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Jan 9, 2020

No description provided.

@softagram-bot
Copy link

Softagram Impact Report for pull/1179 (head commit: fdfdf94)

⚠️ Copy paste found

ℹ️ test_indexing.py: Copy paste fragment inside the same file on lines 566, 584:

                        slice(0, 1)]:
            self.assert_eq(kdf.iloc[:, indexer], pdf.iloc[:, indexer])
            self.assert_eq(kdf.iloc[:1, indexe...(truncated 198 chars)

Now that you are on the file, it would be easier to pay back some tech. debt.

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to support@softagram.com

@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #1179 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1179      +/-   ##
==========================================
- Coverage   95.29%   95.29%   -0.01%     
==========================================
  Files          35       35              
  Lines        7101     7097       -4     
==========================================
- Hits         6767     6763       -4     
  Misses        334      334
Impacted Files Coverage Δ
databricks/koalas/indexing.py 95.96% <100%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 847850e...fdfdf94. Read the comment docs.

@HyukjinKwon HyukjinKwon merged commit 91f4a6b into databricks:master Jan 9, 2020
@ueshin ueshin deleted the indexing branch January 9, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants