Sync with PySpark upstream in Apache Spark #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
force-pushed
the
prepare-spark-3.0
branch
from
d77646f
to
99f1fa0
Compare
HyukjinKwon
commented
Jan 22, 2020
| @@ -325,7 +325,7 @@ def _compute_stats(data, colname, whis, precision): | |||
| # Computes mean, median, Q1 and Q3 with approx_percentile and precision | |||
| pdf = (data._kdf._sdf | |||
| .agg(*[F.expr('approx_percentile({}, {}, {})'.format(colname, q, | |||
| 1. / precision)) | |||
| int(1. / precision))) | |||
There was a problem hiding this comment.
It's because of SPARK-30266
HyukjinKwon
commented
Jan 22, 2020
| @@ -8186,7 +8186,7 @@ def explain(self, extended: bool = False): | |||
| == Optimized Logical Plan == | |||
| ... | |||
| == Physical Plan == | |||
| Scan ExistingRDD[__index_level_0__#...,id#...] | |||
| ... | |||
There was a problem hiding this comment.
Expected:
== Physical Plan ==
Scan ExistingRDD[__index_level_0__#...,id#...]
Got:
== Physical Plan ==
*(1) Scan ExistingRDD[__index_level_0__#9308L,id#9309L]
HyukjinKwon
commented
Jan 22, 2020
| self.assert_eq(kidx.to_series(), pidx.to_series()) | ||
| self.assert_eq(kidx.to_series(name='a'), pidx.to_series(name='a')) | ||
| else: | ||
| with self.sql_conf({'spark.sql.execution.arrow.enabled': False}): |
There was a problem hiding this comment.
Struct type is supported from Spark 3.0. It failed in 2.3 because fallback isn't available there.
In Spark 3.0, it's supported when Arrow optimization is enabled. They produce different results:
E Left:
E b
E 0 4 {'__index_level_0__': 0, 'b': 4}
E 1 5 {'__index_level_0__': 1, 'b': 5}
E 3 6 {'__index_level_0__': 3, 'b': 6}
E 5 3 {'__index_level_0__': 5, 'b': 3}
E 6 2 {'__index_level_0__': 6, 'b': 2}
E 8 1 {'__index_level_0__': 8, 'b': 1}
E 9 0 {'__index_level_0__': 9, 'b': 0}
E 0 {'__index_level_0__': 9, 'b': 0}
E 0 {'__index_level_0__': 9, 'b': 0}
E dtype: object
E object
E
E Right:
E b
E 0 4 (0, 4)
E 1 5 (1, 5)
E 3 6 (3, 6)
E 5 3 (5, 3)
E 6 2 (6, 2)
E 8 1 (8, 1)
E 9 0 (9, 0)
E 0 (9, 0)
E 0 (9, 0)
E dtype: object
E object
Codecov Report
@@ Coverage Diff @@
## master #1211 +/- ##
==========================================
+ Coverage 95.18% 95.18% +<.01%
==========================================
Files 35 35
Lines 7204 7205 +1
==========================================
+ Hits 6857 6858 +1
Misses 347 347
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs Koalas to support PySpark 3.0. It's development purpose mainly.