Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement stack() for DataFrame. #1329

Merged
merged 8 commits into from Mar 10, 2020
Merged

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Mar 6, 2020

@ueshin ueshin requested a review from HyukjinKwon March 6, 2020 05:43
@codecov-io
Copy link

codecov-io commented Mar 6, 2020

Codecov Report

Merging #1329 into master will decrease coverage by 2.22%.
The diff coverage is 97.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1329      +/-   ##
==========================================
- Coverage   95.23%   93.01%   -2.23%     
==========================================
  Files          34       34              
  Lines        7373     7440      +67     
==========================================
- Hits         7022     6920     -102     
- Misses        351      520     +169
Impacted Files Coverage Δ
databricks/koalas/missing/frame.py 81.7% <ø> (-18.3%) ⬇️
databricks/koalas/frame.py 96.04% <97.22%> (-0.68%) ⬇️
databricks/koalas/usage_logging/__init__.py 26.12% <0%> (-69.37%) ⬇️
databricks/koalas/usage_logging/usage_logger.py 50% <0%> (-50%) ⬇️
databricks/koalas/missing/series.py 71.42% <0%> (-28.58%) ⬇️
databricks/koalas/missing/indexes.py 88.8% <0%> (-11.2%) ⬇️
databricks/koalas/__init__.py 91.48% <0%> (-2.13%) ⬇️
databricks/conftest.py 94.33% <0%> (-1.89%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a849249...ec3ff49. Read the comment docs.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

@HyukjinKwon HyukjinKwon merged commit 1974be3 into databricks:master Mar 10, 2020
@ueshin ueshin deleted the stack branch March 10, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame.stack
3 participants