Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations to window.py #1898

Merged
merged 1 commit into from Nov 9, 2020
Merged

Conversation

xinrong-meng
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 9, 2020

Codecov Report

Merging #1898 (a2254a4) into master (3237002) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
- Coverage   94.20%   94.17%   -0.03%     
==========================================
  Files          40       40              
  Lines        9939     9957      +18     
==========================================
+ Hits         9363     9377      +14     
- Misses        576      580       +4     
Impacted Files Coverage Δ
databricks/koalas/window.py 96.75% <100.00%> (ø)
databricks/koalas/generic.py 93.91% <0.00%> (-1.45%) ⬇️
databricks/koalas/internal.py 96.47% <0.00%> (-0.03%) ⬇️
databricks/koalas/base.py 97.36% <0.00%> (-0.02%) ⬇️
databricks/koalas/frame.py 96.73% <0.00%> (+<0.01%) ⬆️
databricks/koalas/groupby.py 91.47% <0.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3237002...a2254a4. Read the comment docs.

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ueshin
Copy link
Collaborator

ueshin commented Nov 9, 2020

Thanks! merging.

@ueshin ueshin merged commit 1ec9072 into databricks:master Nov 9, 2020
@itholic
Copy link
Contributor

itholic commented Nov 10, 2020

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants