Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python type name instead of Spark's in error messages. #1985

Merged
merged 5 commits into from Dec 26, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Dec 23, 2020

Addressing #1980 (comment) to add pandas dtypes.

@codecov-io
Copy link

codecov-io commented Dec 23, 2020

Codecov Report

Merging #1985 (c8520db) into master (5f27857) will not change coverage.
The diff coverage is 45.45%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1985   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files          50       50           
  Lines       10939    10939           
=======================================
  Hits        10343    10343           
  Misses        596      596           
Impacted Files Coverage Δ
databricks/koalas/generic.py 92.61% <33.33%> (ø)
databricks/koalas/frame.py 96.73% <100.00%> (ø)
databricks/koalas/series.py 96.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f27857...c8520db. Read the comment docs.

@ueshin ueshin marked this pull request as draft December 23, 2020 22:39
@ueshin ueshin marked this pull request as ready for review December 24, 2020 00:33
@HyukjinKwon HyukjinKwon merged commit 1e51477 into databricks:master Dec 26, 2020
@ueshin ueshin deleted the spark_type_to_python_type branch December 28, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants