Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Series.to_list #379

Merged
merged 4 commits into from May 24, 2019
Merged

Series.to_list #379

merged 4 commits into from May 24, 2019

Conversation

garawalid
Copy link
Collaborator

Resolves #362

@garawalid
Copy link
Collaborator Author

@HyukjinKwon I'm wondering if we add tolist in series.rst because it's not there in pandas doc.

@codecov-io
Copy link

codecov-io commented May 23, 2019

Codecov Report

Merging #379 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
+ Coverage   94.64%   94.64%   +<.01%     
==========================================
  Files          41       41              
  Lines        4405     4408       +3     
==========================================
+ Hits         4169     4172       +3     
  Misses        236      236
Impacted Files Coverage Δ
databricks/koalas/missing/series.py 100% <ø> (ø) ⬆️
databricks/koalas/series.py 93.25% <100%> (+0.05%) ⬆️
databricks/koalas/tests/test_series.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03304e0...bab14ef. Read the comment docs.

@HyukjinKwon
Copy link
Member

Hm, this one and to_records are actually closer to violate https://github.com/databricks/koalas#guardrails-to-prevent-users-from-shooting-themselves-in-the-foot

Maybe we have to deprecate them or remove in the future. Let me add it for now since we already have to_records

@HyukjinKwon HyukjinKwon merged commit b96d427 into databricks:master May 24, 2019
@HyukjinKwon
Copy link
Member

Thanks, @garawalid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement missing DataFrame/Series/Index APIs
3 participants