New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Series.transform #428
Add Series.transform #428
Conversation
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
==========================================
+ Coverage 94.73% 94.74% +<.01%
==========================================
Files 42 42
Lines 4746 4754 +8
==========================================
+ Hits 4496 4504 +8
Misses 250 250
Continue to review full report at Codecov.
|
699f137
to
0486f3a
Compare
Softagram Impact Report for pull/428 (head commit: 0486f3a)⭐ Change Overview
📄 Full report
Give feedback on this report to support@softagram.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for one question.
if isinstance(func, list): | ||
applied = [] | ||
for f in func: | ||
applied.append(self.apply(f).rename(f.__name__)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we pass args
and kwargs
here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, it's being ignored in pandas' too ...
let me merge. Thanks @ueshin! |
This seems virtually an alias of
Series.apply
(if it's in Series). I revised the doc a bit so that it can be used in DataFrames too in the future.Also,
transform
can take a list of functions that return a dataframe.