Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Series.transform #428

Merged
merged 1 commit into from Jun 5, 2019
Merged

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Jun 4, 2019

This seems virtually an alias of Series.apply (if it's in Series). I revised the doc a bit so that it can be used in DataFrames too in the future.

Also, transform can take a list of functions that return a dataframe.

@codecov-io
Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #428 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
+ Coverage   94.73%   94.74%   +<.01%     
==========================================
  Files          42       42              
  Lines        4746     4754       +8     
==========================================
+ Hits         4496     4504       +8     
  Misses        250      250
Impacted Files Coverage Δ
databricks/koalas/missing/series.py 100% <ø> (ø) ⬆️
databricks/koalas/series.py 93.35% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7418129...0486f3a. Read the comment docs.

@softagram-bot
Copy link

Softagram Impact Report for pull/428 (head commit: 0486f3a)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Give feedback on this report to support@softagram.com

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for one question.

if isinstance(func, list):
applied = []
for f in func:
applied.append(self.apply(f).rename(f.__name__))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pass args and kwargs here as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, it's being ignored in pandas' too ...

@HyukjinKwon HyukjinKwon merged commit 36842b4 into databricks:master Jun 5, 2019
@HyukjinKwon
Copy link
Member Author

let me merge. Thanks @ueshin!

@HyukjinKwon HyukjinKwon deleted the series-transform branch November 6, 2019 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants