Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pow, rpow, mod, rmod, floordiv, rfloordiv in DataFrame and Series #503

Merged
merged 1 commit into from Jun 27, 2019

Conversation

HyukjinKwon
Copy link
Member

This PR adds pow, rpow, mod, rmod, floordiv, rfloordiv in DataFrame and Series

@HyukjinKwon
Copy link
Member Author

This finishes all operator-like implementations.

@codecov-io
Copy link

codecov-io commented Jun 26, 2019

Codecov Report

Merging #503 into master will decrease coverage by 0.22%.
The diff coverage is 78.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
- Coverage   93.87%   93.64%   -0.23%     
==========================================
  Files          30       30              
  Lines        4034     4077      +43     
==========================================
+ Hits         3787     3818      +31     
- Misses        247      259      +12
Impacted Files Coverage Δ
databricks/koalas/missing/frame.py 100% <ø> (ø) ⬆️
databricks/koalas/missing/series.py 100% <ø> (ø) ⬆️
databricks/koalas/frame.py 94.41% <73.33%> (-0.8%) ⬇️
databricks/koalas/base.py 91.33% <75%> (-0.54%) ⬇️
databricks/koalas/series.py 93.23% <85.71%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a96c01f...ea1fbe4. Read the comment docs.

@softagram-bot
Copy link

Softagram Impact Report for pull/503 (head commit: ea1fbe4)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Give feedback on this report to support@softagram.com

@HyukjinKwon
Copy link
Member Author

tests passed

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ueshin
Copy link
Collaborator

ueshin commented Jun 27, 2019

Thanks! merging.

@ueshin ueshin merged commit c6bd969 into databricks:master Jun 27, 2019
@HyukjinKwon
Copy link
Member Author

Thanks @ueshin !!

@HyukjinKwon HyukjinKwon deleted the remainig-ops branch November 6, 2019 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants