Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use column_index. #648

Merged
merged 3 commits into from Aug 19, 2019

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Aug 15, 2019

Now that we introduced multi-index columns, we should use column_index rather than data_columns to be consistent access between single and multi index.
We still have a ways to go, so this includes a workaround to work with the data_columns-based approach.
I will address them in the separate PRs.

@codecov-io
Copy link

codecov-io commented Aug 15, 2019

Codecov Report

Merging #648 into master will decrease coverage by 1.89%.
The diff coverage is 97.72%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #648     +/-   ##
=========================================
- Coverage   93.24%   91.34%   -1.9%     
=========================================
  Files          32       32             
  Lines        5267     5291     +24     
=========================================
- Hits         4911     4833     -78     
- Misses        356      458    +102
Impacted Files Coverage Δ
databricks/koalas/indexes.py 91.58% <ø> (ø) ⬆️
databricks/koalas/series.py 92.93% <100%> (ø) ⬆️
databricks/koalas/indexing.py 92.85% <100%> (-0.54%) ⬇️
databricks/koalas/utils.py 97.98% <100%> (+0.08%) ⬆️
databricks/koalas/internal.py 95.91% <100%> (-0.75%) ⬇️
databricks/koalas/frame.py 94.46% <92.59%> (-0.12%) ⬇️
databricks/koalas/usage_logging/__init__.py 23.14% <0%> (-74.08%) ⬇️
databricks/koalas/usage_logging/usage_logger.py 50% <0%> (-50%) ⬇️
databricks/koalas/__init__.py 76.92% <0%> (-7.7%) ⬇️
databricks/conftest.py 93.02% <0%> (-4.66%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f1859...d28ab34. Read the comment docs.

@softagram-bot
Copy link

Softagram Impact Report for pull/648 (head commit: d28ab34)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

⭐ Details of Dependency Changes

details of dependency changes - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Give feedback on this report to support@softagram.com

@HyukjinKwon HyukjinKwon merged commit e694826 into databricks:master Aug 19, 2019
@ueshin ueshin deleted the fix_multiindex_columns branch August 19, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants