Fix error message for too many arguments with at least one named arg #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsilfer
force-pushed
the
edgar/improve-wrong-message-error-during-function-invocation
branch
from
391bcb5
to
3a1aecf
Compare
iuliand-db
reviewed
Nov 4, 2020
edsilfer
force-pushed
the
edgar/improve-wrong-message-error-during-function-invocation
branch
6 times, most recently
from
a92d8ed
to
54efa34
Compare
iuliand-db
approved these changes
Nov 6, 2020
edsilfer
force-pushed
the
edgar/improve-wrong-message-error-during-function-invocation
branch
from
54efa34
to
717a377
Compare
lihaoyi-databricks
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR fixes issue 83 by changing the error message thrown when two parameters are passed to a function that was expecting only one. The message now matches the official jsonnet.org specification.
How is this tested?
./mill "sjsonnet[2.13.3].jvm.test.testLocal"