Optimizations for a variable and size() for length(). #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
|
I see this was also fixed in Spark, apache/spark@e97fc7f. @falaki Would you maybe merge this? |
rachelwarren
pushed a commit
to rachelwarren/spark-csv
that referenced
this pull request
Sep 29, 2016
I forgot to correct the variable in a past PR. This PR re-use the `rowArray` rather than creating it everytime. This was mentioned before in databricks#169 (comment). In addition, according to IntelliJ IDE, we might have to use `length()` instead of `size()`. ``` This inspection reports array.size and string.size calls. While such calls are legimimate, they require an additional implicit conversion to SeqLike to be made. Considering the common use cases, calling length on arrays and strings may provide significant advantages. ``` Lastly, I gave a `()` for `buildScan()`. Author: hyukjinkwon <gurwls223@gmail.com> Closes databricks#250 from HyukjinKwon/optimization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to correct the variable in a past PR. This PR re-use the
rowArrayrather than creating it everytime. This was mentioned before in #169 (comment).In addition, according to IntelliJ IDE, we might have to use
length()instead ofsize().Lastly, I gave a
()forbuildScan().