Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nested tag names with attributes bug #374

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

jimenefe
Copy link
Contributor

@jimenefe jimenefe commented Jan 3, 2019

Fix for #373

@codecov-io
Copy link

codecov-io commented Jan 3, 2019

Codecov Report

Merging #374 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   87.51%   87.58%   +0.06%     
==========================================
  Files          14       14              
  Lines         737      741       +4     
  Branches       96       91       -5     
==========================================
+ Hits          645      649       +4     
  Misses         92       92
Impacted Files Coverage Δ
...cala/com/databricks/spark/xml/XmlInputFormat.scala 93.38% <100%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0a8b15...6b9ab13. Read the comment docs.

Copy link
Collaborator

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, yeah.
I think that char-at-a-time model here is getting pretty hard to maintain and get right (still doesn't handle commented-out rows) and later maybe we can rewrite the whole thing with a char buffer, marking readers, etc. But that's for later, and this is a fine clean fix.

@HyukjinKwon HyukjinKwon merged commit ca1d4dc into databricks:master Jan 4, 2019
@srowen srowen added the bug label Jan 4, 2019
@srowen srowen added this to the 0.5.1 milestone Jan 4, 2019
@srowen srowen modified the milestones: 0.5.1, 0.6.0 Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants