Fix translation of types like xs:long to LongType, not IntegerType #522
Conversation
| restriction.getBaseTypeName | ||
| } | ||
| matchType match { | ||
| simpleType.getQName match { |
There was a problem hiding this comment.
@seddonm1 this change seems to 'fix' the translation, which otherwise was coming up with xs:int when the schema says xs:long. This was from your original code, and I wasn't sure if there was another reason it has to be done this way? it's already known to be a simple type and seems like you can just get the QName in this case.
There was a problem hiding this comment.
Sorry, I can't remember. At the time this was more a brute force reverse engineering process as the XSD spec is big.
There was a problem hiding this comment.
Got it. I wouldn't want to break your use case - there are some tests but far from comprehensive. I'll try to think about why this would be needed, but I don't know XSDs that well (and at least I know it doesn't work in a simple case here). Thanks!
Codecov Report
@@ Coverage Diff @@
## master #522 +/- ##
==========================================
+ Coverage 86.63% 86.82% +0.18%
==========================================
Files 18 18
Lines 928 926 -2
Branches 81 82 +1
==========================================
Hits 804 804
+ Misses 124 122 -2
Continue to review full report at Codecov.
|
No description provided.