Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaned up the files and added golanglintci file #102

Merged
merged 3 commits into from Jun 15, 2020
Merged

Conversation

stikkireddy
Copy link
Contributor

@stikkireddy stikkireddy commented Jun 15, 2020

Updated the makefile to use golanglintci file

Fixed make build bug:

  • fixed a bug where make build just runs format before running build so travis never fails.

make fmt now:

  1. applies import resorting
  2. gofmt -s which simplifies code.

Fixed the following:

  1. fixed trailing whitespace
  2. Import formatting issues
  3. Typos
  4. IfElse chains -> switch statements
  5. simplify value = otherValue + value to value += otherValue
  6. Allowed parameter interface types from io.ReadCloser -> io.Reader

…kefile is set to lint with the file, also added goimports and gofmt -s for simplifying code, and removed if else chains with switch
@stikkireddy stikkireddy requested a review from nfx June 15, 2020 12:19
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #102 into master will decrease coverage by 0.06%.
The diff coverage is 20.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   47.79%   47.72%   -0.07%     
==========================================
  Files          53       53              
  Lines        6884     6893       +9     
==========================================
  Hits         3290     3290              
- Misses       3543     3552       +9     
  Partials       51       51              
Flag Coverage Δ
#client 76.45% <82.35%> (ø)
#provider 39.45% <0.00%> (-0.07%) ⬇️
Impacted Files Coverage Δ
client/service/clusters.go 100.00% <ø> (ø)
client/service/instance_pools.go 85.71% <ø> (ø)
client/service/instance_profiles.go 100.00% <ø> (ø)
client/service/jobs.go 100.00% <ø> (ø)
client/service/libraries.go 100.00% <ø> (ø)
client/service/mask_utils.go 75.51% <ø> (ø)
client/service/mws_credentials.go 0.00% <ø> (ø)
client/service/mws_customer_managed_keys.go 0.00% <ø> (ø)
client/service/mws_networks.go 0.00% <0.00%> (ø)
client/service/mws_storage_configurations.go 0.00% <ø> (ø)
... and 31 more

@nfx nfx merged commit 8998fb4 into master Jun 15, 2020
@nfx nfx deleted the cleanup-and-tests branch June 15, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants