Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devcontainer to support ARM #1256

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Update devcontainer to support ARM #1256

merged 2 commits into from
Apr 22, 2022

Conversation

fjakobs
Copy link
Contributor

@fjakobs fjakobs commented Apr 22, 2022

this will enable M1 Mac users to develop in dev containers.

Also had to update the version go go to 1.18.1 to make it work.

@fjakobs fjakobs requested a review from nfx April 22, 2022 13:38
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #1256 (3cbdce2) into master (7a1f2ef) will decrease coverage by 0.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1256      +/-   ##
==========================================
- Coverage   90.64%   89.86%   -0.79%     
==========================================
  Files         117      117              
  Lines        9943     9943              
==========================================
- Hits         9013     8935      -78     
- Misses        552      630      +78     
  Partials      378      378              
Impacted Files Coverage Δ
exporter/util.go 67.04% <0.00%> (-13.64%) ⬇️
exporter/importables.go 86.22% <0.00%> (-5.10%) ⬇️
exporter/context.go 82.64% <0.00%> (-4.69%) ⬇️

this will enable M! Mac users to develop in dev containers.

Also had to update the version go go to 1.18.1 to make it work.
Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking up dev container, it needs some occasional love :)

Please also stick to Go 1.16 for now

.devcontainer/Dockerfile Show resolved Hide resolved
.devcontainer/Dockerfile Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
also mount less folders from the host to make dev environment more repeatable.
@nfx nfx merged commit 40c1d53 into master Apr 22, 2022
@nfx nfx deleted the devcontainer-arm branch April 22, 2022 15:49
@nfx nfx mentioned this pull request Apr 29, 2022
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
* Update devcontainer to support ARM
* this will enable M1 Mac users to develop in dev containers.
* use golang base image to simplify dockerfile
* also mount less folders from the host to make dev environment more repeatable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants