Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for general permissions #132

Merged
merged 47 commits into from Jun 25, 2020
Merged

Add support for general permissions #132

merged 47 commits into from Jun 25, 2020

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Jun 22, 2020

No description provided.

@nfx nfx requested a review from stikkireddy June 22, 2020 19:50
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2020 •
edited

Codecov Report

Merging #132 into master will increase coverage by 0.82%.
The diff coverage is 55.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   48.02%   48.85%   +0.82%     
==========================================
  Files          58       60       +2     
  Lines        7219     7420     +201     
==========================================
+ Hits         3467     3625     +158     
- Misses       3690     3719      +29     
- Partials       62       76      +14
Flag Coverage Δ
#client 73.56% <49.51%> (-1.77%) ⬇️
#provider 41.83% <57.04%> (+1.36%) ⬆️
#repository 48.85% <55.03%> (?)
Impacted Files Coverage Δ
client/service/apis.go 68.62% <0.00%> (-2.81%) ⬇️
client/service/permissions.go 0.00% <0.00%> (ø)
client/service/secret_scopes.go 75.67% <0.00%> (-9.18%) ⬇️
client/service/secrets.go 80.00% <0.00%> (-7.81%) ⬇️
databricks/azure_auth.go 0.00% <0.00%> (ø)
...ricks/resource_databricks_azure_adls_gen1_mount.go 37.33% <0.00%> (ø)
...ricks/resource_databricks_azure_adls_gen2_mount.go 37.10% <0.00%> (ø)
databricks/resource_databricks_azure_blob_mount.go 36.23% <0.00%> (ø)
databricks/resource_databricks_cluster_policy.go 35.61% <0.00%> (-2.07%) ⬇️
databricks/resource_databricks_dbfs_file.go 35.64% <0.00%> (+1.02%) ⬆️
... and 30 more

@nfx nfx linked an issue Jun 22, 2020 that may be closed by this pull request
[FEATURE] Cluster Policies Resource #29
Closed
@nfx nfx self-assigned this Jun 23, 2020
nfx and others added 6 commits June 24, 2020 00:07
@nfx
Added real unit tests for resource
78f8b72
@nfx
trigger build
8865b03
@nfx
trigger build
391e80f
@stikkireddy
Merge branch 'master' into permissions-api
4f5c730
@stikkireddy
bump aws-sdk-go from 1.32.2 to 1.32.6; bump terraform-plugin-sdk from…
20a38ae 
… 1.13.1 to 1.14.0; added travisbuddy notification hooks for public repo (#133)
@nfx @stikkireddy
Add more readability for errors (#129)
6f50437 
* Add resource wait retry for workspace create

* Made vscode integration testing simpler

* added read support for username/password for config files

* Made errors concise and explainable

* Fix formatting issue

* cleaned up token request structs

* make fmt

* Added some documentation

* keying composite literals

* Add resource wait retry for workspace create

* Made vscode integration testing simpler

* added read support for username/password for config files

* Made errors concise and explainable

* Fix formatting issue

* cleaned up token request structs

* make fmt

* Added some documentation

* keying composite literals

* Add missing resource check in resourceClusterPolicyRead

* Apply review comments

* More correct implementation of 404-check

* Make README more user-friendly

* More links

* added integration test to verify that all apis can either handle 404s or check the error message to verify resource is missing; added travis buddy integration; added unit test for handling errors; deprecated dbfs file sync; doc fix for scim user;

* added skip for testMissingWorkspaceResources to run only if TF_ACC is set so it runs with both aws and azure integration tests

* cleaned up makefile

* refactored tokenexpirytime to the api client config so the client is aware of expiry time of token as metadata; added getAndAssetEnv for generating the dbapi client for testing missing errors

* added a int test missing cluster policy

* adjusted the headers on the index and added the id attribute for cluster policy

* corrected typos

* fix another credentials typo

Co-authored-by: Serge Smertin <serge.smertin@databricks.com>
Co-authored-by: Sriharsha Tikkireddy <sri.tikkireddy@databricks.com>
@TravisBuddy
Copy link

Travis tests have failed

Hey @nfx,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

2nd Build

View build log

curl -sSL "https://github.com/gotestyourself/gotestsum/releases/download/v0.4.2/gotestsum_0.4.2_linux_amd64.tar.gz" | sudo tar -xz -C /usr/local/bin gotestsum 
The command "curl -sSL "https://github.com/gotestyourself/gotestsum/releases/download/v0.4.2/gotestsum_0.4.2_linux_amd64.tar.gz" | sudo tar -xz -C /usr/local/bin gotestsum" exited with 0.
$ curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.25.0
golangci/golangci-lint info checking GitHub for tag 'v1.25.0'
golangci/golangci-lint info found version: 1.25.0 for v1.25.0/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint
The command "curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.25.0" exited with 0.
$ time make build
==> Formatting source code with gofmt...
make: goimports: Command not found
Makefile:18: recipe for target 'fmt' failed
make: *** [fmt] Error 127

real	0m0.007s
user	0m0.003s
sys	0m0.000s
The command "time make build" exited with 2.
store build cache
nothing changed


Done. Your build exited with 1.
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.25.0 
golangci/golangci-lint info checking GitHub for tag 'v1.25.0'
golangci/golangci-lint info found version: 1.25.0 for v1.25.0/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint
time make build 
==> Formatting source code with gofmt...
make: goimports: Command not found
Makefile:18: recipe for target 'fmt' failed
make: *** [fmt] Error 127

real	0m0.007s
user	0m0.003s
sys	0m0.000s
TravisBuddy Request Identifier: c2f2d720-b6d7-11ea-bb0d-6965ce86ea0c

@TravisBuddy
Copy link

Hey @nfx,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 78b37a70-b6dc-11ea-bb0d-6965ce86ea0c

@TravisBuddy
Copy link

Hey @nfx,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 3c0ab0f0-b6de-11ea-bb0d-6965ce86ea0c

stikkireddy
stikkireddy approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@stikkireddy stikkireddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@nfx nfx added this to the v0.2.0 milestone Jun 25, 2020
@nfx nfx added the feature New feature or request label Jun 25, 2020
@TravisBuddy
Copy link

Hey @nfx,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 24f53280-b6e0-11ea-bb0d-6965ce86ea0c

@TravisBuddy
Copy link

Hey @nfx,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 0a20a5b0-b6e1-11ea-bb0d-6965ce86ea0c

@nfx nfx merged commit 6a54e54 into master Jun 25, 2020
@nfx nfx deleted the permissions-api branch June 25, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stikkireddy stikkireddy stikkireddy approved these changes

Assignees

@nfx nfx

Labels
feature New feature or request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

[FEATURE] Cluster Policies Resource
4 participants
@nfx @codecov-commenter @TravisBuddy @stikkireddy