Fix databricks_user creation with force on account
#1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexott
reviewed
Sep 2, 2022
scim/resource_user.go
Outdated
| force := fmt.Sprintf("User with username %s already exists.", userName) | ||
| force := fmt.Sprintf("User with email %s already exists in this account", userName) |
There was a problem hiding this comment.
Will it continue to work with the workspace level identities?
There was a problem hiding this comment.
you are correct - updated the correct error message
scim/resource_user_test.go
Outdated
| fmt.Errorf("User with username me@example.com already exists."), | ||
| fmt.Errorf("User with email me@example.com already exists in this account"), |
There was a problem hiding this comment.
Maybe move this format string into a constant, or create a function that will accept email & return string?
There was a problem hiding this comment.
refactored the error messages into a function
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1577 +/- ##
=======================================
Coverage 90.15% 90.16%
=======================================
Files 132 132
Lines 10629 10631 +2
=======================================
+ Hits 9583 9585 +2
Misses 667 667
Partials 379 379
|
alexott
approved these changes
Sep 2, 2022
nkvuong
changed the title
databricks_user creation with force on account
nfx
approved these changes
Sep 2, 2022
nfx
force-pushed
the
fix/force_user_creation
branch
from
df45a9a
to
c23c099
Compare
nfx
force-pushed
the
fix/force_user_creation
branch
from
c23c099
to
24c8b08
Compare
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend API changes error messages, updating code to match
Closes #1549