Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improvements of exporter #1602

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Further improvements of exporter #1602

merged 1 commit into from
Sep 14, 2022

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Sep 14, 2022

This is a separate PR for things found during improving SQL exporting (separate PR):

  • Make sure that names are unique for databricks_group_member and databricks_group resources - handling same names with different casing, and missing DisplayName for users
  • Change selective export for DLT pipelines - built-in search wasn't case insensitive
  • Adding export of SQL warehouses & handling references correctly for SQL & DBT tasks in databricks_job

@alexott alexott requested a review from a team September 14, 2022 11:46
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #1602 (277e6a1) into master (44941f0) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1602      +/-   ##
==========================================
- Coverage   90.18%   90.05%   -0.14%     
==========================================
  Files         135      135              
  Lines       10812    10825      +13     
==========================================
- Hits         9751     9748       -3     
- Misses        675      688      +13     
- Partials      386      389       +3     
Impacted Files Coverage Δ
exporter/importables.go 90.68% <100.00%> (-1.07%) ⬇️
exporter/context.go 85.79% <0.00%> (-1.64%) ⬇️

This is a separate PR for things found during improving SQL exporting:

* Make sure that names are unique for `databricks_group_member` and `databricks_group`
  resources - handling same names with different casing, and missing `DisplayName` for
  users
* Change selective export for DLT pipelines - built-in search wasn't case insensitive
* Adding export of SQL warehouses & handling references correctly for SQL & DBT tasks in
  `databricks_job`
@nfx nfx merged commit af30395 into master Sep 14, 2022
@nfx nfx deleted the improving-exporter branch September 14, 2022 12:22
@nfx nfx mentioned this pull request Sep 23, 2022
nfx added a commit that referenced this pull request Sep 23, 2022
# Version changelog

## 1.3.1

 * Added autoscale `mode` configuration to [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) resource ([#1600](#1600)).
 * Fixed `gcp_availability` field in [databricks_insance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/insance_pool) resource ([#1610](#1610)).
 * Fixed `secret` field name in [databricks_mlflow_webhook](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mlflow_webhook) resource ([#1625](#1625)).
 * Further improvements of exporter ([#1602](#1602)).

 Documentation improvements:
 
 * Updates for [databricks_table](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/table) and [databricks_mws_vpc_endpoint](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mws_vpc_endpoint) ([#1616](#1616)).
 * Document `http_timeout_seconds` from `common/client.go` ([#1599](#1599)).
 * Expand `parameter` documentation for [databricks_sql_query](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_query) resource ([#1603](#1603)).
 * Updated Unity Catalog docs ([#1605](#1605), [#1626](#1626), [#1620](#1620)).

 Updated dependency versions:

 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.21.0 to 2.23.0 ([#1597](#1597), [#1611](#1611)).
 * Bump google.golang.org/api from 0.94.0 to 0.96.0 ([#1598](#1598), [#1612](#1612)).
nkvuong pushed a commit that referenced this pull request Oct 6, 2022
# Version changelog

## 1.3.1

 * Added autoscale `mode` configuration to [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) resource ([#1600](#1600)).
 * Fixed `gcp_availability` field in [databricks_insance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/insance_pool) resource ([#1610](#1610)).
 * Fixed `secret` field name in [databricks_mlflow_webhook](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mlflow_webhook) resource ([#1625](#1625)).
 * Further improvements of exporter ([#1602](#1602)).

 Documentation improvements:
 
 * Updates for [databricks_table](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/table) and [databricks_mws_vpc_endpoint](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mws_vpc_endpoint) ([#1616](#1616)).
 * Document `http_timeout_seconds` from `common/client.go` ([#1599](#1599)).
 * Expand `parameter` documentation for [databricks_sql_query](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_query) resource ([#1603](#1603)).
 * Updated Unity Catalog docs ([#1605](#1605), [#1626](#1626), [#1620](#1620)).

 Updated dependency versions:

 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.21.0 to 2.23.0 ([#1597](#1597), [#1611](#1611)).
 * Bump google.golang.org/api from 0.94.0 to 0.96.0 ([#1598](#1598), [#1612](#1612)).
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
This is a separate PR for things found during improving SQL exporting:

* Make sure that names are unique for `databricks_group_member` and `databricks_group`
  resources - handling same names with different casing, and missing `DisplayName` for
  users
* Change selective export for DLT pipelines - built-in search wasn't case insensitive
* Adding export of SQL warehouses & handling references correctly for SQL & DBT tasks in
  `databricks_job`
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
# Version changelog

## 1.3.1

 * Added autoscale `mode` configuration to [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) resource ([databricks#1600](databricks#1600)).
 * Fixed `gcp_availability` field in [databricks_insance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/insance_pool) resource ([databricks#1610](databricks#1610)).
 * Fixed `secret` field name in [databricks_mlflow_webhook](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mlflow_webhook) resource ([databricks#1625](databricks#1625)).
 * Further improvements of exporter ([databricks#1602](databricks#1602)).

 Documentation improvements:
 
 * Updates for [databricks_table](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/table) and [databricks_mws_vpc_endpoint](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mws_vpc_endpoint) ([databricks#1616](databricks#1616)).
 * Document `http_timeout_seconds` from `common/client.go` ([databricks#1599](databricks#1599)).
 * Expand `parameter` documentation for [databricks_sql_query](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_query) resource ([databricks#1603](databricks#1603)).
 * Updated Unity Catalog docs ([databricks#1605](databricks#1605), [databricks#1626](databricks#1626), [databricks#1620](databricks#1620)).

 Updated dependency versions:

 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.21.0 to 2.23.0 ([databricks#1597](databricks#1597), [databricks#1611](databricks#1611)).
 * Bump google.golang.org/api from 0.94.0 to 0.96.0 ([databricks#1598](databricks#1598), [databricks#1612](databricks#1612)).
@alexott alexott added the exporter TF configuration generator label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter TF configuration generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants