Allow to override resource ID for specific data source #1885

alexott · 2022-12-29T16:27:41Z

The DataResource function now checks if the provided schema has the field with name id and set its value as resource ID. This will allow to have uniform references between normal resources and data sources. If this change is ok, then I'll proceed with other data sources. (See hashicorp/terraform-plugin-sdk#607 for reference about definition of id attribute).

This change was already applied to the databricks_service_principal data source where old attribute (sp_id) was left for backward compatibility.

codecov-commenter · 2022-12-29T16:32:35Z

Codecov Report

Merging #1885 (2daec42) into master (242ff84) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1885   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files         143      143           
  Lines       11443    11448    +5     
=======================================
+ Hits        10321    10326    +5     
  Misses        712      712           
  Partials      410      410

Impacted Files	Coverage Δ
common/resource.go	`92.85% <100.00%> (+0.19%)`	⬆️
scim/data_service_principal.go	`100.00% <100.00%> (ø)`

common/resource.go

docs/data-sources/service_principal.md

The `DataResource` function now checks if the provided schema has the field with name `id` and set its value as resource ID. This will allow to have uniform references between normal resources and data sources. If this change is ok, then I'll proceed with other data sources. See hashicorp/terraform-plugin-sdk#607 for reference.

alexott · 2022-12-30T14:00:15Z

@nfx feedback was incorporated

Also expose `id` for `databricks_cluster` & `databricks_job` data sources so it's easier to use results. This is a follow up for #1885

* add search by name for `databricks_cluster` data source Also expose `id` for `databricks_cluster` & `databricks_job` data sources so it's easier to use results. This is a follow up for #1885 * address review feedback

# Version changelog ### 1.8.0 * Added support for GCP (Public Preview) with state upgraders for [databricks_mws_workspaces](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mws_workspaces) ([#1871](#1871), [#1886](#1886), [#1748](#1748), [#1879](#1879)). * Added documentation for [databricks_permission_assignment](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/permission_assignment) ([#1880](#1880)). * Added `azure_attributes` to clusters in [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) resource ([#1854](#1854)). * Added [databricks_instance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/instance_pool) data source ([#1907](#1907)). * Added [databricks_provider](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/provider) resource for Delta Sharing ([#1572](#1572)). * Added acceptance tests for [databricks_cluster](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/cluster) data and [databricks_sql_endpoint](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/sql_endpoint) data ([#1882](#1882)). * Added search by name for [databricks_cluster](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/cluster) data source ([#1901](#1901)). * Added support for sparse checkouts in the [databricks_repo](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/repo) ([#1869](#1869)). * Added `config_reference` attribute to [databricks_secret](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/secret) for easier reference from Spark configuration ([#1898](#1898)). * Added `datarbicks_directory` data source ([#1902](#1902)). * Extended [databricks_catalog](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/catalog) resource to support Delta Sharing Catalog ([#1887](#1887)). * Improved [databricks_metastore_assignment](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/metastore_assignment) resource ([#1900](#1900)). * Improved [databricks_grants](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/grants) error messages ([#1888](#1888)). * Improved [databricks_group](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/group) documentation ([#1816](#1816)). * Improved `data_security_mode` documentation for [databricks_cluster](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/cluster) ([#1830](#1830)). * Replace the incorrect `id` attribute with the correct `sp_id` in service principal data source docs example ([#1873](#1873)). * Use NVMe disk size for selection in the [databricks_node_type](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/node_type) data source ([#1856](#1856)). * Allowed to override resource ID for specific data source ([#1885](#1885)). Experimental Resource Exporter * Added command-line flag to export all users and service principals ([#1893](#1893)). * Added emit for secret scopes from Spark Conf and Env Vars ([#1897](#1897)). * Fixed issue with exporting of resources with simple name ([#1891](#1891)). * Generate references that are matching only to a prefix ([#1890](#1890)). * Updated list of supported services and associated resources ([#1894](#1894)). * Use [databricks_group_role](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/group_role) instead of deprecated [databricks_group_instance_profile](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/group_instance_profile) ([#1905](#1905)). * Use `dbfs_path` as reference for init scripts in clusters ([#1892](#1892)). * Logging improvements ([#1895](#1895)). Updated dependency versions: * Bump google.golang.org/api from 0.104.0 to 0.105.0 ([#1863](#1863)).

* Allow to override resource ID for specific data source The `DataResource` function now checks if the provided schema has the field with name `id` and set its value as resource ID. This will allow to have uniform references between normal resources and data sources. If this change is ok, then I'll proceed with other data sources. See hashicorp/terraform-plugin-sdk#607 for reference. * address PR feedback

…#1901) * add search by name for `databricks_cluster` data source Also expose `id` for `databricks_cluster` & `databricks_job` data sources so it's easier to use results. This is a follow up for databricks#1885 * address review feedback

alexott requested review from nfx, nkvuong and a team December 29, 2022 16:27

alexott force-pushed the data-resource-set-id branch from 11564c1 to b086db4 Compare December 29, 2022 16:29

alexott force-pushed the data-resource-set-id branch from b086db4 to 4258d78 Compare December 29, 2022 16:36

nfx approved these changes Dec 29, 2022

View reviewed changes

common/resource.go Show resolved Hide resolved

docs/data-sources/service_principal.md Outdated Show resolved Hide resolved

alexott added 2 commits December 30, 2022 14:54

address PR feedback

91694c1

alexott force-pushed the data-resource-set-id branch from 4cd0213 to 91694c1 Compare December 30, 2022 13:54

nkvuong approved these changes Dec 30, 2022

View reviewed changes

nfx approved these changes Jan 3, 2023

View reviewed changes

nfx enabled auto-merge (squash) January 3, 2023 10:38

nfx and others added 2 commits January 3, 2023 11:38

Merge branch 'master' into data-resource-set-id

2daec42

Merge branch 'master' into data-resource-set-id

af1c6db

nfx merged commit 607484c into master Jan 4, 2023

alexott deleted the data-resource-set-id branch January 4, 2023 07:34

alexott added a commit that referenced this pull request Jan 4, 2023

add search by name for databricks_cluster data source

0af8ea7

Also expose `id` for `databricks_cluster` & `databricks_job` data sources so it's easier to use results. This is a follow up for #1885

alexott mentioned this pull request Jan 4, 2023

add search by name for databricks_cluster data source #1901

Merged

alexott added a commit that referenced this pull request Jan 4, 2023

add search by name for databricks_cluster data source

4c77cb2

Also expose `id` for `databricks_cluster` & `databricks_job` data sources so it's easier to use results. This is a follow up for #1885

alexott added a commit that referenced this pull request Jan 4, 2023

add search by name for databricks_cluster data source

de8c11c

Also expose `id` for `databricks_cluster` & `databricks_job` data sources so it's easier to use results. This is a follow up for #1885

nfx mentioned this pull request Jan 10, 2023

Release v1.8.0 #1915

Merged

nkvuong mentioned this pull request Mar 27, 2023

[ISSUE] Issue with databricks_group_member resource #2071

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow to override resource ID for specific data source #1885

Allow to override resource ID for specific data source #1885

alexott commented Dec 29, 2022 •

edited

Loading

codecov-commenter commented Dec 29, 2022 •

edited

Loading

alexott commented Dec 30, 2022

Allow to override resource ID for specific data source #1885

Allow to override resource ID for specific data source #1885

Conversation

alexott commented Dec 29, 2022 • edited Loading

codecov-commenter commented Dec 29, 2022 • edited Loading

Codecov Report

alexott commented Dec 30, 2022

alexott commented Dec 29, 2022 •

edited

Loading

codecov-commenter commented Dec 29, 2022 •

edited

Loading