Fixed incorrect diff for num_clusters and min_num_clusters for stopped databricks_sql_endpoint
#1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly suppress diff for `num_clusters` on warehouses that are not running, in case `num_clusters` is not specified. Note for contributors: `tf:"suppress_diff"` and `tf:"default"` don't work well together. Fix #1204
alexott
requested changes
Jan 16, 2023
sql/resource_sql_endpoint.go
Outdated
| @@ -27,7 +27,7 @@ type SQLEndpoint struct { | |||
| AutoStopMinutes int `json:"auto_stop_mins" tf:"optional,default:120"` | |||
| MinNumClusters int `json:"min_num_clusters,omitempty" tf:"default:1,suppress_diff"` | |||
There was a problem hiding this comment.
Should we do the same for MinNumClusters ?
nfx
changed the title
num_clusters for stopped databricks_sql_endpointnum_clusters and min_num_clusters for stopped databricks_sql_endpoint
|
@alexott having a sound CI system makes me sometimes forget running tests locally. Added the same fix for |
nfx
added a commit
that referenced
this pull request
Jan 17, 2023
# Version changelog ### 1.9.0 * Added [databricks_mws_credentials](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/mws_credentials) data source ([#1909](#1909)). * Fixed incorrect diff for `num_clusters` and `min_num_clusters` for stopped [databricks_sql_endpoint](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_endpoint) ([#1927](#1927)). * Fixed `privilege_assignment` in [databricks_sql_permissions](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_permissions) ([#1872](#1872)). * Documentation improvements ([#1921](#1921), [#1923](#1923)). Updated dependency versions: * Bump github.com/hashicorp/go-retryablehttp from 0.7.1 to 0.7.2 ([#1913](#1913)). * Bump google.golang.org/api from 0.105.0 to 0.106.0 ([#1914](#1914)).
Merged
nfx
added a commit
that referenced
this pull request
Jan 17, 2023
# Version changelog ### 1.9.0 * Added [databricks_mws_credentials](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/mws_credentials) data source ([#1909](#1909)). * Fixed incorrect diff for `num_clusters` and `min_num_clusters` for stopped [databricks_sql_endpoint](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_endpoint) ([#1927](#1927)). * Fixed `privilege_assignment` in [databricks_sql_permissions](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_permissions) ([#1872](#1872)). * Documentation improvements ([#1921](#1921), [#1923](#1923)). Updated dependency versions: * Bump github.com/hashicorp/go-retryablehttp from 0.7.1 to 0.7.2 ([#1913](#1913)). * Bump google.golang.org/api from 0.105.0 to 0.106.0 ([#1914](#1914)).
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
…opped `databricks_sql_endpoint` (databricks#1927) Correctly suppress diff for `num_clusters` on warehouses that are not running, in case `num_clusters` is not specified. Note for contributors: `tf:"suppress_diff"` and `tf:"default"` don't work well together.
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
# Version changelog ### 1.9.0 * Added [databricks_mws_credentials](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/mws_credentials) data source ([databricks#1909](databricks#1909)). * Fixed incorrect diff for `num_clusters` and `min_num_clusters` for stopped [databricks_sql_endpoint](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_endpoint) ([databricks#1927](databricks#1927)). * Fixed `privilege_assignment` in [databricks_sql_permissions](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_permissions) ([databricks#1872](databricks#1872)). * Documentation improvements ([databricks#1921](databricks#1921), [databricks#1923](databricks#1923)). Updated dependency versions: * Bump github.com/hashicorp/go-retryablehttp from 0.7.1 to 0.7.2 ([databricks#1913](databricks#1913)). * Bump google.golang.org/api from 0.105.0 to 0.106.0 ([databricks#1914](databricks#1914)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly suppress diff for
num_clusterson warehouses that are not running, in casenum_clustersis not specified.Note for contributors:
tf:"suppress_diff"andtf:"default"don't work well together.Fixes #1204 #1743