Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

databricks_mount S3: Use zone_id:"auto" #1932

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Conversation

marekbrysa
Copy link
Contributor

@marekbrysa marekbrysa commented Jan 17, 2023

This way Databricks will automatically choose the zone in the given region where the default instance type can be created.

Resolves #1756.

@codecov-commenter
Copy link

Codecov Report

Merging #1932 (875b7c5) into master (fd1f11a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1932   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files         146      146           
  Lines       11843    11844    +1     
=======================================
+ Hits        10682    10683    +1     
  Misses        748      748           
  Partials      413      413           
Impacted Files Coverage Δ
storage/aws_s3_mount.go 87.65% <100.00%> (+0.15%) ⬆️

@marekbrysa marekbrysa requested a review from nfx January 17, 2023 16:29
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marekbrysa aws_s3_mount is deprecated in favor of databricks_mount and will be removed in the next major version - we won't make any changes in aws_s3_mount

@marekbrysa
Copy link
Contributor Author

@alexott please correct me if I'm wrong, but I think my change will get used with databricks_mount like this:

if err := preprocessS3MountGeneric(ctx, scm, d, m); err != nil {

return mountS3ViaProfileAndSetClusterID(clustersAPI, instanceProfile, d)

cluster, err := GetOrCreateMountingClusterWithInstanceProfile(clustersAPI, instanceProfile)

So I am changing the code related to databricks_mount?

@nfx nfx enabled auto-merge (squash) January 23, 2023 18:17
@nfx nfx merged commit f708fa6 into databricks:master Jan 23, 2023
@nfx nfx mentioned this pull request Jan 25, 2023
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Issue with databricks_mount resource
4 participants