Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "computed" annotation for "aws_attributes" #1933

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Jan 17, 2023

This annotation means the field shows up in plans for Azure and GCP, where it doesn't make sense.

It was added in #1463. Not clear if it was intentional at that time.

This annotation means the field shows up in plans for Azure and GCP, where it doesn't make sense.
@pietern pietern requested review from nfx and alexott January 17, 2023 18:55
@pietern
Copy link
Contributor Author

pietern commented Jan 17, 2023

I confirmed that after removing the annotation, aws_attributes no longer shows up in the plans for Azure and GCP.

@codecov-commenter
Copy link

Codecov Report

Merging #1933 (68edfa1) into master (fd1f11a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1933   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files         146      146           
  Lines       11843    11843           
=======================================
  Hits        10682    10682           
  Misses        748      748           
  Partials      413      413           
Impacted Files Coverage Δ
pools/resource_instance_pool.go 100.00% <ø> (ø)

Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, if pr-manual checks pass on azure-prod and gcp-prod

Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pietern
Copy link
Contributor Author

pietern commented Jan 18, 2023

Integration tests passed.

@pietern pietern merged commit 78e45f7 into databricks:master Jan 18, 2023
@pietern pietern deleted the instance-pool-aws-attributes branch January 18, 2023 07:47
@nfx nfx mentioned this pull request Jan 25, 2023
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
This annotation means the field shows up in plans for Azure and GCP, where it doesn't make sense.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants