Add acc test for databricks_tables data source
#2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
acc test passed |
nfx
requested changes
Mar 7, 2023
| @@ -21,7 +21,7 @@ func DataSourceTables() *schema.Resource { | |||
| } | |||
| for _, v := range tables { | |||
| if v.TableType != "VIEW" { | |||
| data.Ids = append(data.Ids, v.Name) | |||
| data.Ids = append(data.Ids, v.FullName) | |||
There was a problem hiding this comment.
you're changing the expected output - customers expect name instead of full name for tables data
There was a problem hiding this comment.
because #2068 changed FullName -> Name, this fixes it by changing it back 😅
nfx
approved these changes
Mar 7, 2023
nfx
added a commit
that referenced
this pull request
Mar 9, 2023
* Added databricks_model_serving resource (#2054). * Added Unity Catalog on GCP support (#2000). * Deprecate schedule block in databricks_sql_query resource (#2078). * Fixed InitScripts Type to work with GCS and ABFS in databricks_cluster resource (#2067). * Added more testing for databricks_tables data source (#2075). * Added more testing for databricks_schemas data source (#2074). * Migrate databricks_node_type data source to Go SDK (#2070). * Migrate databricks_schemas data to Go SDK (#2065). * Migrate databricks_tables data source to SDK (#2068). * Migrate databricks_views data source to Go SDK (#2073). * Migrated databricks_git_credential to Go SDK (#2069). * Migrated databricks_shares data source to Go SDK (#2072). Updated dependency versions: * Bump github.com/databricks/databricks-sdk-go from v0.3.3 to v0.4.0 (#2086). * Bump golang.org/x/mod from 0.8.0 to 0.9.0 (#2076).
Merged
nfx
added a commit
that referenced
this pull request
Mar 9, 2023
* Added databricks_model_serving resource (#2054). * Added Unity Catalog on GCP support (#2000). * Deprecate schedule block in databricks_sql_query resource (#2078). * Fixed InitScripts Type to work with GCS and ABFS in databricks_cluster resource (#2067). * Added more testing for databricks_tables data source (#2075). * Added more testing for databricks_schemas data source (#2074). * Migrate databricks_node_type data source to Go SDK (#2070). * Migrate databricks_schemas data to Go SDK (#2065). * Migrate databricks_tables data source to SDK (#2068). * Migrate databricks_views data source to Go SDK (#2073). * Migrated databricks_git_credential to Go SDK (#2069). * Migrated databricks_shares data source to Go SDK (#2072). Updated dependency versions: * Bump github.com/databricks/databricks-sdk-go from v0.3.3 to v0.4.0 (#2086). * Bump golang.org/x/mod from 0.8.0 to 0.9.0 (#2076).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.