[PLAT-73750] Add TF for GCP PSC workspace. #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2090 +/- ##
=======================================
Coverage 89.68% 89.68%
=======================================
Files 136 136
Lines 11105 11107 +2
=======================================
+ Hits 9959 9961 +2
Misses 741 741
Partials 405 405
|
jessiedu-db
force-pushed
the
PLAT-73750-3
branch
from
24a28ae
to
56d2988
Compare
grayluck
reviewed
Mar 9, 2023
docs/resources/mws_workspaces.md
Outdated
| @@ -300,26 +300,29 @@ output "databricks_token" { | |||
| } | |||
| ``` | |||
|
|
|||
| In order to create a [Databricks Workspace that leverages GCP Private Service Connect](https://docs.gcp.databricks.com/administration-guide/cloud-configurations/gcp/private-service-connect.html) please ensure that you have read and understood the [Enable Private Service Connect](https://docs.gcp.databricks.com/administration-guide/cloud-configurations/gcp/private-service-connect.html) documentation and then customise the example above with the relevant examples from [mws_vpc_endpoint](mws_vpc_endpoint.md), [mws_private_access_settings](mws_private_access_settings.md) and [mws_networks](mws_networks.md). | |||
There was a problem hiding this comment.
This doc block should be added to "Creating a Databricks on GCP workspace" section instead of "Creating a Databricks on GCP workspace with Databricks-Managed VPC" section.
grayluck
suggested changes
Mar 9, 2023
nfx
requested changes
Mar 10, 2023
| @@ -122,6 +122,9 @@ func (w *Workspace) MarshalJSON() ([]byte, error) { | |||
| if w.NetworkID != "" { | |||
| workspaceCreationRequest["network_id"] = w.NetworkID | |||
| } | |||
| if w.PrivateAccessSettingsID != "" { | |||
| workspaceCreationRequest["private_access_settings_id"] = w.PrivateAccessSettingsID | |||
There was a problem hiding this comment.
is this for both AWS & GCP or for gcp only?
There was a problem hiding this comment.
This field is for both AWS & GCP.
jessiedu-db
force-pushed
the
PLAT-73750-3
branch
2 times, most recently
from
51e5eda
to
595e699
Compare
jessiedu-db
commented
Mar 10, 2023
| @@ -122,6 +122,9 @@ func (w *Workspace) MarshalJSON() ([]byte, error) { | |||
| if w.NetworkID != "" { | |||
| workspaceCreationRequest["network_id"] = w.NetworkID | |||
| } | |||
| if w.PrivateAccessSettingsID != "" { | |||
| workspaceCreationRequest["private_access_settings_id"] = w.PrivateAccessSettingsID | |||
There was a problem hiding this comment.
This field is for both AWS & GCP.
jessiedu-db
force-pushed
the
PLAT-73750-3
branch
from
595e699
to
a2eeb86
Compare
jessiedu-db
force-pushed
the
PLAT-73750-3
branch
from
a2eeb86
to
88e9f27
Compare
nfx
approved these changes
Mar 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.