fix edge cases for databricks_permissions resource
#2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
acceptance tests passed on all 3 clouds |
nfx
requested changes
Mar 28, 2023
| if strings.ToLower(v) == "admins" { | ||
| return diag.Diagnostics{ | ||
| { | ||
| Summary: "It is not possible to restrict any permissions from `admins`.", |
There was a problem hiding this comment.
why? it'll keep popping up in the diff
There was a problem hiding this comment.
I moved this logic down to Create (same place where we validate decreasing permission for current users), as it is possible to set permission on authorization/passwords for admins #2087
nfx
approved these changes
Mar 31, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2158 +/- ##
==========================================
- Coverage 88.74% 88.74% -0.01%
==========================================
Files 137 137
Lines 11217 11208 -9
==========================================
- Hits 9955 9947 -8
+ Misses 853 852 -1
Partials 409 409
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix edge cases when setting permissions for root directory and password/token usage
Closes #2087
closes #2134
Tests
make testrun locallydocs/folderinternal/acceptance