Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: put empty_result_state under options in the databricks_sql_alert resource #2834

Merged
merged 1 commit into from Oct 25, 2023

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Oct 24, 2023

Changes

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@alexott alexott requested review from a team as code owners October 24, 2023 18:02
@alexott alexott requested review from tanmay-db and removed request for a team October 24, 2023 18:02
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@cb4a6f0). Click here to learn what that means.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2834   +/-   ##
=========================================
  Coverage          ?   84.65%           
=========================================
  Files             ?      152           
  Lines             ?    13240           
  Branches          ?        0           
=========================================
  Hits              ?    11208           
  Misses            ?     1418           
  Partials          ?      614           

@alexott alexott added the docs add explicit documentation about corner case label Oct 25, 2023
@alexott alexott added this pull request to the merge queue Oct 25, 2023
Merged via the queue into master with commit 8ab1dbe Oct 25, 2023
7 checks passed
@alexott alexott deleted the sql-alert-doc-fix branch October 25, 2023 12:33
@mgyucht mgyucht mentioned this pull request Oct 25, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs add explicit documentation about corner case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants