Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporter: Ignore workspace assets of deleted users and service principals #2980

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Dec 2, 2023

Changes

Don't export workspace objects (notebooks, workspace files, and directories) of deleted users and service principals. Otherwise, when importing into another workspace it will be attempted to create them, and the apply step will fail as we can't create folders under the /Users folder.

It doesn't cover other objects of deleted users, like SQL queries/alerts/dashboards - this may come in the next PRs.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@alexott alexott added the exporter TF configuration generator label Dec 2, 2023
@alexott alexott requested review from a team as code owners December 2, 2023 08:48
@alexott alexott requested review from tanmay-db and removed request for a team December 2, 2023 08:48
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0d6281c) 84.11% compared to head (7176010) 84.08%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2980      +/-   ##
==========================================
- Coverage   84.11%   84.08%   -0.03%     
==========================================
  Files         159      159              
  Lines       13929    13937       +8     
==========================================
+ Hits        11716    11719       +3     
  Misses       1546     1546              
- Partials      667      672       +5     
Files Coverage Δ
exporter/command.go 82.60% <100.00%> (+0.38%) ⬆️
exporter/context.go 79.38% <ø> (ø)
exporter/importables.go 73.93% <66.66%> (-0.14%) ⬇️
exporter/util.go 77.66% <87.80%> (-0.43%) ⬇️

@alexott alexott force-pushed the exporter-ignore-deleted-users branch from be106f2 to 7176010 Compare December 20, 2023 08:59
@mgyucht mgyucht added this pull request to the merge queue Dec 20, 2023
Merged via the queue into master with commit 5d1cedf Dec 20, 2023
7 checks passed
@mgyucht mgyucht deleted the exporter-ignore-deleted-users branch December 20, 2023 10:49
@tanmay-db tanmay-db mentioned this pull request Dec 20, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter TF configuration generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants