Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an item to check if the ticket opener wants to do a bug fix #3020

Merged

Conversation

case-k-git
Copy link
Contributor

@case-k-git case-k-git commented Dec 12, 2023

Changes

Added an item to check if the ticket opener wants to do a bug fix, referring to the AWS side of Terraform
https://github.com/hashicorp/terraform-provider-aws/issues

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@case-k-git case-k-git requested review from a team as code owners December 12, 2023 00:30
@case-k-git case-k-git requested review from tanmay-db and removed request for a team December 12, 2023 00:30
@case-k-git case-k-git changed the title update issue template Added an item to check if the ticket opener wants to do a bug fix Dec 12, 2023
@@ -11,29 +11,42 @@ Thank you for opening an issue. Please note that we try to keep the Databricks P
-->

### Configuration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these and other whitespaces between section and comments . The new line gives separation between different section when someone uses the template. If we have white spaces then it makes it a bit confusing on whether to write between the section and comment or after comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanmay-db
Thank you for your check I removed
9ce4b43

Copy link
Contributor

@tanmay-db tanmay-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this looks good. We should have this section in our other public repositories as well. This could help encourage more open source contributions. cc: @pietern @fjakobs @mgyucht

@case-k-git case-k-git force-pushed the feature/update-issue-pr-template branch from 3d1cb79 to 9ce4b43 Compare December 12, 2023 04:23
@codecov-commenter
Copy link

Codecov Report

Merging #3020 (9ce4b43) into master (1ff9e88) will not change coverage.
Report is 3 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3020   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files         158      158           
  Lines       13803    13803           
=======================================
  Hits        11647    11647           
  Misses       1506     1506           
  Partials      650      650           

@alexott alexott added this pull request to the merge queue Dec 21, 2023
Merged via the queue into databricks:master with commit efc02a3 Dec 21, 2023
7 checks passed
@tanmay-db tanmay-db mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants