Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: remove confusing mention of cloud types for databricks_clusters and databricks_sql_warehouses data sources #3518

Merged
merged 1 commit into from
May 1, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Apr 27, 2024

Changes

Fixes #3513

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

…s` and `databricks_sql_warehouses` data sources

Fixes #3513
@alexott alexott requested review from a team as code owners April 27, 2024 07:19
@alexott alexott requested review from hectorcast-db and removed request for a team April 27, 2024 07:19
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@472a48b). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3518   +/-   ##
=======================================
  Coverage        ?   82.06%           
=======================================
  Files           ?      184           
  Lines           ?    17178           
  Branches        ?        0           
=======================================
  Hits            ?    14097           
  Misses          ?     2189           
  Partials        ?      892           

@nkvuong nkvuong added this pull request to the merge queue Apr 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 30, 2024
@alexott alexott added this pull request to the merge queue May 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 1, 2024
@alexott alexott added this pull request to the merge queue May 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 1, 2024
@nkvuong nkvuong added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit 7d41711 May 1, 2024
5 checks passed
@nkvuong nkvuong deleted the issue-3513 branch May 1, 2024 18:41
mgyucht added a commit that referenced this pull request May 3, 2024
### New Features and Improvements
* Allow changes to `display_name` for `databricks_service_principal` ([#3523](#3523)).
* Modify `databricks_repo` to support Git folders in the workspace ([#3447](#3447)).
* Retry requests in the Databricks Go SDK until context timeout ([#3537](#3537)).
* Set ForceSendFields for boolean/integer values explicitly set to false/0 ([#3385](#3385)).

### Bug fixes
* Added `ConflictsWith` to legacy tasks in `databricks_job` to avoid errors when job parameters are used ([#3500](#3500)).
* Fixed spn secret permanent diff ([#3525](#3525)).
* Introduced `common.NoClientData` helper function and use it in `databricks_aws_crossaccount_policy` data source to allow its use with workspace- or account-level providers ([#3508](#3508)).
* Set `id` attribute of `databricks_metastore` data source ([#3503](#3503)).

### Documentation Changes
* Added documentation for compute options for tasks in `databricks_job` resource ([#3504](#3504)).
* Added warning about depends_on order ([#3489](#3489)).
* Fixed various doc typos ([#3512](#3512)).
* Fixed `databricks_current_metastore` data source names in docs examples ([#3515](#3515)).
* Improved Job documentation structure ([#3511](#3511)).
* Removed confusing mention of cloud types for `databricks_clusters` and `databricks_sql_warehouses` data sources ([#3518](#3518)).

### Exporter
* Added UC support for DLT pipelines ([#3494](#3494)).
* Ignored instance pools with the empty name ([#3522](#3522)).

### Internal Changes
* Added DATABRICKS_USER_AGENT_EXTRA ([#3520](#3520)).
* Adjusted list of supported platforms in `godownloader-databricks-provider.sh` ([#3527](#3527)).
* Switched to Go SDK for `databricks_directory` resource and data source ([#3509](#3509)).
* Fixed codecov for repository ([#3530](#3530)).

Dependency updates:

 * Bump databricks-sdk-go to v0.40.0 ([#3534](#3534)).
@mgyucht mgyucht mentioned this pull request May 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 3, 2024
* Release v1.42.0

### New Features and Improvements
* Allow changes to `display_name` for `databricks_service_principal` ([#3523](#3523)).
* Modify `databricks_repo` to support Git folders in the workspace ([#3447](#3447)).
* Retry requests in the Databricks Go SDK until context timeout ([#3537](#3537)).
* Set ForceSendFields for boolean/integer values explicitly set to false/0 ([#3385](#3385)).

### Bug fixes
* Added `ConflictsWith` to legacy tasks in `databricks_job` to avoid errors when job parameters are used ([#3500](#3500)).
* Fixed spn secret permanent diff ([#3525](#3525)).
* Introduced `common.NoClientData` helper function and use it in `databricks_aws_crossaccount_policy` data source to allow its use with workspace- or account-level providers ([#3508](#3508)).
* Set `id` attribute of `databricks_metastore` data source ([#3503](#3503)).

### Documentation Changes
* Added documentation for compute options for tasks in `databricks_job` resource ([#3504](#3504)).
* Added warning about depends_on order ([#3489](#3489)).
* Fixed various doc typos ([#3512](#3512)).
* Fixed `databricks_current_metastore` data source names in docs examples ([#3515](#3515)).
* Improved Job documentation structure ([#3511](#3511)).
* Removed confusing mention of cloud types for `databricks_clusters` and `databricks_sql_warehouses` data sources ([#3518](#3518)).

### Exporter
* Added UC support for DLT pipelines ([#3494](#3494)).
* Ignored instance pools with the empty name ([#3522](#3522)).

### Internal Changes
* Added DATABRICKS_USER_AGENT_EXTRA ([#3520](#3520)).
* Adjusted list of supported platforms in `godownloader-databricks-provider.sh` ([#3527](#3527)).
* Switched to Go SDK for `databricks_directory` resource and data source ([#3509](#3509)).
* Fixed codecov for repository ([#3530](#3530)).

Dependency updates:

 * Bump databricks-sdk-go to v0.40.0 ([#3534](#3534)).

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Example Usage of Retrieving all clusters
3 participants