New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes new_cluster missing in the request #79
Conversation
@gnarik this should resolve your issue. |
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=======================================
Coverage 47.27% 47.27%
=======================================
Files 53 53
Lines 6815 6815
=======================================
Hits 3222 3222
Misses 3539 3539
Partials 54 54
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixed my issue. That said, I would have added a small unit test to avoid further regression.
@Gnarik hey thanks for the feedback, I will add an integration test to test this resource object, unfortunately AFAIK Terraform does not provide a great way to unit test with the schema resource object so I will instead create an integration test, to test the creation of this resource object. |
Hi, what's the plan for the merge of this branch ? Just trying to understand your workflow :) |
…rm into fix-job-new-cluster
…or both azure and aws
Hi @stikkireddy, thank for the quick answer. |
Fixes: #75, error was introduced by a prior pull request: #36