Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes new_cluster missing in the request #79

Merged
merged 4 commits into from Jun 10, 2020
Merged

Conversation

stikkireddy
Copy link
Contributor

Fixes: #75, error was introduced by a prior pull request: #36

@stikkireddy stikkireddy changed the title fixes prefix missing the period fixes new_cluster missing in the request Jun 1, 2020
@stikkireddy
Copy link
Contributor Author

@gnarik this should resolve your issue.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2020

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #79   +/-   ##
=======================================
  Coverage   47.27%   47.27%           
=======================================
  Files          53       53           
  Lines        6815     6815           
=======================================
  Hits         3222     3222           
  Misses       3539     3539           
  Partials       54       54           
Flag Coverage Δ
#client 76.45% <ø> (ø)
#provider 38.74% <0.00%> (ø)
Impacted Files Coverage Δ
databricks/resource_databricks_cluster.go 42.49% <0.00%> (ø)
databricks/resource_databricks_job.go 51.20% <0.00%> (ø)

Copy link

@rparme rparme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed my issue. That said, I would have added a small unit test to avoid further regression.

@stikkireddy
Copy link
Contributor Author

@Gnarik hey thanks for the feedback, I will add an integration test to test this resource object, unfortunately AFAIK Terraform does not provide a great way to unit test with the schema resource object so I will instead create an integration test, to test the creation of this resource object.

@rparme
Copy link

rparme commented Jun 9, 2020

Hi, what's the plan for the merge of this branch ? Just trying to understand your workflow :)

@stikkireddy
Copy link
Contributor Author

@Gnarik please let me know the changes should fix #75 and #81

@stikkireddy stikkireddy linked an issue Jun 10, 2020 that may be closed by this pull request
@rparme
Copy link

rparme commented Jun 10, 2020

Hi @stikkireddy, thank for the quick answer.
This PR fixes both #75 and #81

@stikkireddy stikkireddy merged commit 6137b83 into master Jun 10, 2020
@stikkireddy stikkireddy linked an issue Jun 10, 2020 that may be closed by this pull request
@stikkireddy stikkireddy deleted the fix-job-new-cluster branch June 15, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants