Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardised the validate logic found azure mounts #95

Merged
merged 5 commits into from Jun 12, 2020

Conversation

storey247
Copy link

@storey247 storey247 commented Jun 12, 2020

  • Moved validation logic for azure mounts to central place
  • Added validation function to the adls gen 2 mount
  • Added unit tests for the validation logic

This PR fixes issue #94

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #95 into master will increase coverage by 0.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   47.26%   47.79%   +0.52%     
==========================================
  Files          53       53              
  Lines        6838     6884      +46     
==========================================
+ Hits         3232     3290      +58     
+ Misses       3553     3543      -10     
+ Partials       53       51       -2     
Flag Coverage Δ
#client 76.45% <ø> (ø)
#provider 39.51% <100.00%> (+0.75%) ⬆️
Impacted Files Coverage Δ
databricks/mounts.go 1.80% <100.00%> (+1.80%) ⬆️
...ricks/resource_databricks_azure_adls_gen1_mount.go 37.33% <100.00%> (+15.45%) ⬆️
...ricks/resource_databricks_azure_adls_gen2_mount.go 37.10% <100.00%> (+0.39%) ⬆️
databricks/resource_databricks_azure_blob_mount.go 36.23% <100.00%> (+14.56%) ⬆️

@stikkireddy
Copy link
Contributor

Hey looks great! thanks again @storey247 much appreciated 😃

@stikkireddy stikkireddy merged commit 3f56ba9 into databricks:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants