Implement a new error strategy for simplifying error messages #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage tests results394 tests ±0 357 ✅ ±0 4s ⏱️ ±0s For more details on these failures, see this check. Results for commit da25f59. ± Comparison against base commit 3df786c. ♻️ This comment has been updated with latest results. |
jimidle
force-pushed
the
feature/simplifyid
branch
from
d034f61
to
5a97bcc
Compare
…so that we can have useful errors - May also be useful for customers down the line.
jimidle
force-pushed
the
feature/simplifyid
branch
from
5a97bcc
to
da25f59
Compare
nfx
approved these changes
Jul 9, 2024
| msg.append(" was unexpected ") | ||
| msg.append(generateMessage(recognizer, e)) | ||
| msg.append("\nexpecting one of: ") | ||
| msg.append(buildExpectedMessage(recognizer, e.getExpectedTokens)) |
There was a problem hiding this comment.
use interpolated stings: val msg = s"${getTokenErrorDisplay(e.getOffendingToken)} was unexpected ..." - more readable
There was a problem hiding this comment.
Will. do - @vil1 also suggested the same
Comment on lines
+46
to
+47
| val stack = e.getStackTrace | ||
| stack.foreach { traceElement => |
There was a problem hiding this comment.
Suggested change
| val stack = e.getStackTrace | |
| stack.foreach { traceElement => | |
| val messages = e.getStackTrace.flatMap { traceElement => ... |
flatMap would be more idiomatic here.
| * @return | ||
| * the expected string with tokens renamed in more human friendly form | ||
| */ | ||
| import scala.collection.mutable |
There was a problem hiding this comment.
can you move the import to the top?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we implement a new error strategy for constructing error messages such that they are actually useful instead of listing out 780 possible tokens that were expected.