Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tox] update env to avoid exit 1 error #350

Merged
merged 1 commit into from
Jul 21, 2023
Merged

[tox] update env to avoid exit 1 error #350

merged 1 commit into from
Jul 21, 2023

Conversation

R7L208
Copy link
Contributor

@R7L208 R7L208 commented Jul 20, 2023

Removing a line that looks for coverage file based on tox env. Coverage runs tests in parallel so added a guid to the end of the env name making it undiscoverable.

After running tox -e to run tests a user can see the coverage report by running tox -e coverage-report.

@R7L208 R7L208 requested a review from tnixon July 20, 2023 22:02
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #350 (2ab1811) into master (776218e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   87.72%   87.72%           
=======================================
  Files           6        6           
  Lines         872      872           
  Branches      177      177           
=======================================
  Hits          765      765           
  Misses         81       81           
  Partials       26       26           

@R7L208 R7L208 changed the title remove line causing exit 1 due to undiscoverable coverage file [tox] update env to avoid exit 1 error Jul 20, 2023
Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnixon tnixon merged commit 85f58d3 into master Jul 21, 2023
13 checks passed
@tnixon tnixon deleted the minor-tox-fix branch July 21, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants