Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff between Revisions #6

Closed
sfrique opened this issue Apr 13, 2017 · 10 comments
Closed

Diff between Revisions #6

sfrique opened this issue Apr 13, 2017 · 10 comments

Comments

@sfrique
Copy link

sfrique commented Apr 13, 2017

Hello,

It would be great if it was possible to diff between already released versions.

Something like this, current release history:

$ helm history winsome-owl                                                                                                                                             [11:04:28]
REVISION        UPDATED                         STATUS          CHART           DESCRIPTION     
1               Wed Apr 12 18:23:28 2017        SUPERSEDED      api-0.1.0    Install complete
2               Wed Apr 12 18:25:55 2017        SUPERSEDED      api-0.1.0    Upgrade complete
3               Wed Apr 12 18:30:48 2017        SUPERSEDED      api-0.1.0    Upgrade complete
4               Wed Apr 12 18:32:39 2017        SUPERSEDED      api-0.1.0    Rollback to 2   
5               Thu Apr 13 00:08:00 2017        DEPLOYED        api-0.1.0    Upgrade complete

So to get a diff between revision 5 (current and 3)

$ helm diff winsome-owl 3

Or explicit get the diff between 4 and 1

$ helm diff winsome-owl 4-1

Thanks
@databus23 databus23 mentioned this issue Apr 26, 2017
Closed
@codenio
Copy link
Contributor

codenio commented Dec 16, 2017

Waiting for this feature..!!
Mean while, as a work around , we could use the helm get and sdiff/vimdiff to view the difference between two revisions side by side.

Using sdiff:

$ sdiff <(helm get $release --revision $revision_1 ) <(helm get $release --revision $revision_2)

To display only the changes use -s and -w flags

$ sdiff -s -w 80 <(helm get $release --revision $revision_1 ) <(helm get $release --revision $revision_2)

Using vimdiff:

$ vimdiff <(helm get $release --revision $revision_1 ) <(helm get $release --revision $revision_2)

Example:

$ sdiff <(helm get my_release --revision 4 ) <(helm get my_release --revision 5 )
REVISION: 4						      |	REVISION: 5
RELEASED: Fri Dec 15 08:59:48 2017			      |	RELEASED: Fri Dec 15 09:02:09 2017
...                                                           | ....

@codenio
Copy link
Contributor

codenio commented Jan 21, 2018

hi @sfrique,
I have implemented the above mentioned feature in this PR #21, have a look and let me know in case of corrections/bugs.

@sfrique
Copy link
Author

sfrique commented Jan 21, 2018

@aananthraj Thanks a lot to take sometime to implement this!

Unfortunately I don't have the time to test it now =/
But when i get a change i will.

I am currently working on some charts, I may try to use this to see if it will help!

Thanks again for the effort!

codenio referenced this issue in codenio/helm-diff Jan 24, 2018
@codenio
feature Implementing: Diff between Revisions #6
81d477f
@codenio
Copy link
Contributor

codenio commented Mar 12, 2018

@sfrique any updates..?
your inputs would be helpful for closing this issue.

@sfrique
Copy link
Author

sfrique commented Mar 13, 2018

I will test it at beginning of April.
Sorry about the long delay.

@sfrique
Copy link
Author

sfrique commented Mar 30, 2018

@aananthraj this PR says it's messed up.
What should i do?

@codenio
Copy link
Contributor

codenio commented Apr 5, 2018 •
edited

@sfrique , can you be brief..?, couldn't understand.
Is PR #22 messed up...?

@sfrique
Copy link
Author

sfrique commented Apr 5, 2018

@aananthraj i was checking PR #21
Sorry, will test once i have some time!

jeff-knurek pushed a commit to jeff-knurek/helm-diff that referenced this issue Apr 12, 2018
FLAG: allow option for chart version
e85580c 
The first issue databus23#1 and one of the first PRs are still open on this topic.
I think databus23#6 is an entirely unrelated proposal, and if `helm` allows for different version on install, I want to see the diff of what gets installed with that.
@jeff-knurek jeff-knurek mentioned this issue Apr 12, 2018
Closed
codenio referenced this issue in codenio/helm-diff Apr 26, 2018
@Aananth1995
Merge branch 'feature/revision-diff' of https://github.com/aananthraj…
4b0ee6b 
…/helm-diff into feature/revision-diff

* 'feature/revision-diff' of https://github.com/aananthraj/helm-diff:
  adding --suppres and --suppres-secrets flags to subcommands
  removing revison from diffCmd
  make no-color as global flag
  Fix Makefile
  feature Implementing: Diff between Revisions #6
databus23 added a commit that referenced this issue Apr 26, 2018
@databus23
Merge pull request #22 from aananthraj/feature/revision-diff
9beb907 
feature Implementation: Diff between Revisions #6
@databus23
Copy link
Owner

I believe this has been fixed by a536dfc and is shipped since version 2.9.0+1 of this plugin.

@PhilipSchmid
Copy link

Small note to the comment from @codenio: You know have to use helm get values since helm get alone does not have a --revision flag (anymore?) (tested with Helm v3.6.0). Example:

vimdiff <(helm get values prometheus-operator --revision 14) <(helm get values prometheus-operator --revision 13)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@databus23 @sfrique @PhilipSchmid @codenio