Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gender lang fix2 #40

Merged
merged 12 commits into from
Jan 5, 2018
Merged

Gender lang fix2 #40

merged 12 commits into from
Jan 5, 2018

Conversation

richierocks
Copy link
Contributor

I think this is the minimal fix for the gender-related language.

chapter4.Rmd Outdated
@@ -418,7 +412,7 @@ test_object("factor_survey_vector", eq_condition = "equal", undefined_msg = msg,
test_object("male", undefined_msg = msg, incorrect_msg = msg)
test_object("female", undefined_msg = msg, incorrect_msg = msg)
test_output_contains("male > female", incorrect_msg = msg)
success_msg("Phew, it seems that R is gender-neutral. Or maybe it just wants to stay out of these discussions ;-).")
success_msg("Phew, it seems that R is not a sexist language.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd make this just a standard "Good job." success_msg.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated via be438ff

chapter4.Rmd Outdated
@@ -19,7 +19,7 @@ The term factor refers to a statistical data type used to store categorical vari

It is important that R knows whether it is dealing with a continuous or a categorical variable, as the statistical models you will develop in the future treat both types differently. (You will see later why this is the case.)

A good example of a categorical variable is the variable 'Gender'. A human individual can either be "Male" or "Female", making abstraction of inter-sexes. So here "Male" and "Female" are, in a simplified sense, the two values of the categorical variable "Gender", and every observation can be assigned to either the value "Male" of "Female".
A good example of a categorical variable is sex. In many circumstances you can limit the sex categories to "Male" or "Female". (Sometimes you may need different categories. For example, you may need to consider chromosomal variation or hermaphroditic animals, but you will always have a finite number of categories.)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"…you may need to consider chromosomal variation, hermaphroditic animals, or different cultural norms, but you will always…"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed via 7ae518f

chapter4.Rmd Outdated
@@ -214,7 +208,7 @@ When you first get a data set, you will often notice that it contains factors wi
levels(factor_vector) <- c("name1", "name2",...)
```

A good illustration is the raw data that is provided to you by a survey. A standard question for every questionnaire is the gender of the respondent. You remember from the previous question that this is a factor and when performing the questionnaire on the streets its levels are often coded as `"M"` and `"F"`.
A good illustration is the raw data that is provided to you by a survey. A standard question for every questionnaire is the sex of the respondent. You remember from the previous question that this is a factor and when performing the questionnaire on the streets its levels are often coded as `"M"` and `"F"`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"A common question is the sex of the respondent, which is still often over-simplified to "M" and "F". However many categories there are, this is a factor."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated via a36c792

chapter4.Rmd Outdated
@@ -363,10 +357,10 @@ skills: 1
key: 90ecc160d1ebf2f75bf53f9c3843fc1632bdd0a5
```

In `factor_survey_vector` we have a factor with two levels: Male and Female. But how does R value these relatively to each other? In other words, who does R think is better, males or females?
You might wonder what happens when you try to compare elements of a factor. In `factor_survey_vector` you have a factor with two levels: `"Male"` and `"Female"`. But how does R value these relatively to each other? In other words, who does R think is greater, males or females?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"In other words, which does R think should come first in sorted data, males or females?"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Greater" is used because the question is about using then greater than operator on factor values. So I think I'm happy with the sentence as it is.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @gvwilson that this phrasing is fraught. Maybe rephrase as:

In other words, which level does R consider to be greater, male or female?

Therfore, we avoid using the word "value", and also by using inline code for male and female it is clear that we aren't referring to men and women in general.

Copy link
Contributor

@yashasroy yashasroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ncarchedi I tested on Teach and Campus and this is good to merge.

Copy link
Contributor

@ncarchedi ncarchedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yashasroy just two small tweaks then we're ready to merge

chapter4.Rmd Outdated
@@ -363,10 +357,10 @@ skills: 1
key: 90ecc160d1ebf2f75bf53f9c3843fc1632bdd0a5
```

In `factor_survey_vector` we have a factor with two levels: Male and Female. But how does R value these relatively to each other? In other words, who does R think is better, males or females?
You might wonder what happens when you try to compare elements of a factor. In `factor_survey_vector` you have a factor with two levels: `"Male"` and `"Female"`. But how does R value these relatively to each other? In other words, who does R think is greater, males or females?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"relatively" --> "relative". Also, why not just cut the last sentence? It's annoying and unnecessary.

@yashasroy
Copy link
Contributor

@ncarchedi Assignment text has been edited.

Copy link
Contributor

@ncarchedi ncarchedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yashasroy LGTM, go ahead and merge.

@yashasroy yashasroy merged commit d5ba668 into master Jan 5, 2018
@yashasroy yashasroy deleted the gender-lang-fix2 branch January 5, 2018 23:47
This was referenced Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants